Skip to content

Fix intermittent docId unit test failure #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timvandermeij opened this issue Aug 1, 2021 · 2 comments · Fixed by #13839
Closed

Fix intermittent docId unit test failure #13838

timvandermeij opened this issue Aug 1, 2021 · 2 comments · Fixed by #13839
Labels

Comments

@timvandermeij
Copy link
Contributor

timvandermeij commented Aug 1, 2021

The TEST-UNEXPECTED-FAIL | checks that docIds are unique and increasing | in chrome | Expected 9 to be less than 0 unit test failed in a recent test run in #13837 (comment), but also locally once for me. Perhaps this goes wrong because the test depends on state that might be mutated if the tests are shuffled?

/cc @Snuffleupagus since this unit test was added in b18620a

@timvandermeij timvandermeij changed the title Fix intermittent Fix intermittent docId unit test failure Aug 1, 2021
@timvandermeij
Copy link
Contributor Author

Ah, maybe the problem is that the + needs to be inside the paretheses at b18620a#diff-bc84ed767f5905bdf8c544c715c08e9b751e7bb1db16c8182d9de515b56bc4b6R400 since otherwise it only matches one digit in case the number is 10 for example?

@Snuffleupagus
Copy link
Collaborator

Whoops, sorry about this and thanks for pin-pointing the problem in #13838 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants