Skip to content

XFA - Cannot open a pdf because of a typo in xfa/config.js #13679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
calixteman opened this issue Jul 6, 2021 · 2 comments
Closed

XFA - Cannot open a pdf because of a typo in xfa/config.js #13679

calixteman opened this issue Jul 6, 2021 · 2 comments
Labels
form-xfa

Comments

@calixteman
Copy link
Contributor

Attach (recommended) or Link to PDF file here:
Form_MGT-7.pdf

When we try to open the above pdf, we get in the console:

Warning: XFA - an error occured during parsing and binding: TypeError: x.include is not a function

which is caused by a typo:

pdf.js/src/core/xfa/config.js

Line 174 in b9e84ba

.filter(x => !!x && x.include(":"))

So fixing the typo allows to open the pdf but there is only 1 page when we have 9 in using masterpdfeditor.
calixteman added a commit to calixteman/pdf.js that referenced this issue Jul 6, 2021
@calixteman
XFA - Default background in rectangle is white
3ef16f1 
  - Fix a typo in order to open the pdf in issue mozilla#13679
  - After fixing the fill default color there wer some regressions because of z-index
    and when fixing z-index there were some regressions because of borders
  - So fix the borders rendering.
@calixteman calixteman mentioned this issue Jul 6, 2021
Merged
calixteman added a commit to calixteman/pdf.js that referenced this issue Jul 6, 2021
@calixteman
XFA - Default background in rectangle is white
c47f0f0 
  - Fix a typo in order to open the pdf in issue mozilla#13679
  - After fixing the fill default color there wer some regressions because of z-index
    and when fixing z-index there were some regressions because of borders
  - So fix the borders rendering.
@marco-c
Copy link
Contributor

marco-c commented Jul 6, 2021

@calixteman is this fixed by #13684?

@marco-c
Copy link
Contributor

marco-c commented Jul 7, 2021

Yes, it's fixed.

@marco-c marco-c closed this as completed Jul 7, 2021
@calixteman calixteman mentioned this issue Sep 3, 2021
Closed
bh213 pushed a commit to bh213/pdf.js that referenced this issue Jun 3, 2022
@calixteman @bh213
XFA - Default background in rectangle is white
52721c0 
  - Fix a typo in order to open the pdf in issue mozilla#13679
  - After fixing the fill default color there wer some regressions because of z-index
    and when fixing z-index there were some regressions because of borders
  - So fix the borders rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marco-c @calixteman