Skip to content

Collect telemetry on all unsupported features #11961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emalysz opened this issue Jun 2, 2020 · 2 comments
Closed

Collect telemetry on all unsupported features #11961

emalysz opened this issue Jun 2, 2020 · 2 comments
Labels

Comments

@emalysz
Copy link
Contributor

emalysz commented Jun 2, 2020

In #11815, we collected telemetry on what error triggered the fallback bar. The first error message is what is shown in the fallback bar. We need expand this and collect telemetry on all error messages to give us a better understanding of the frequency of each type of error.

Example with more than one error:
https://www.irs.gov/pub/irs-pdf/f1040.pdf

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jun 2, 2020

One possible way of doing this could be to decouple the showing of the fallback bar from the reporting of telemetry data, to not complicate e.g. the PDFViewerApplication.fallback method unnecessarily; perhaps something along these lines:

emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 4, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
@emalysz
Copy link
Contributor Author

emalysz commented Jun 4, 2020

Upstream bug to add telemetry in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1643402

emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 5, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 8, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 11, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 11, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 11, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
emalysz added a commit to emalysz/pdf.js that referenced this issue Jun 11, 2020
…es that trigger fallback error.

This expands upon the telemetry we are collecting that shows the fallback error.
timvandermeij added a commit that referenced this issue Jun 12, 2020
…metry-error

For #11961: collect telemetry on all unique unsupported features that…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants