Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use cargo-action-fmt to highlight issues #2578

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larseggert
Copy link
Collaborator

Let's see if this is helpful.

Let's see if this is helpful.
Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 28c0ea7.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

Benchmark results

Performance differences relative to 28c0ea7.

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [713.64 ms 717.83 ms 721.98 ms]
       thrpt:  [138.51 MiB/s 139.31 MiB/s 140.13 MiB/s]
change:
       time:   [-0.2734% +0.5729% +1.4357%] (p = 0.17 > 0.05)
       thrpt:  [-1.4154% -0.5696% +0.2742%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [350.02 ms 351.77 ms 353.51 ms]
       thrpt:  [28.287 Kelem/s 28.428 Kelem/s 28.570 Kelem/s]
change:
       time:   [-1.1209% -0.3664% +0.3144%] (p = 0.34 > 0.05)
       thrpt:  [-0.3134% +0.3677% +1.1336%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: 💚 Performance has improved.
       time:   [25.079 ms 25.241 ms 25.409 ms]
       thrpt:  [39.357  elem/s 39.618  elem/s 39.874  elem/s]
change:
       time:   [-3.4294% -2.5946% -1.7243%] (p = 0.00 < 0.05)
       thrpt:  [+1.7545% +2.6637% +3.5511%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💚 Performance has improved.
       time:   [1.8469 s 1.8684 s 1.8911 s]
       thrpt:  [52.881 MiB/s 53.522 MiB/s 54.146 MiB/s]
change:
       time:   [-17.323% -15.941% -14.569%] (p = 0.00 < 0.05)
       thrpt:  [+17.053% +18.963% +20.953%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

decode 4096 bytes, mask ff: Change within noise threshold.
       time:   [12.027 µs 12.082 µs 12.148 µs]
       change: [+0.2833% +0.7698% +1.3797%] (p = 0.01 < 0.05)

Found 19 outliers among 100 measurements (19.00%)
2 (2.00%) low severe
2 (2.00%) low mild
15 (15.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [2.9558 ms 2.9654 ms 2.9767 ms]
       change: [-0.1433% +0.2987% +0.7444%] (p = 0.20 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
9 (9.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [20.014 µs 20.068 µs 20.125 µs]
       change: [-0.4940% -0.0662% +0.3204%] (p = 0.77 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
2 (2.00%) low severe
2 (2.00%) low mild
1 (1.00%) high mild
13 (13.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [4.7969 ms 4.8085 ms 4.8216 ms]
       change: [-0.3520% +0.0239% +0.3806%] (p = 0.91 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
13 (13.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.3197 µs 6.3495 µs 6.3862 µs]
       change: [-0.7846% -0.0350% +0.7253%] (p = 0.93 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
6 (6.00%) low severe
1 (1.00%) low mild
3 (3.00%) high mild
8 (8.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [2.1490 ms 2.1558 ms 2.1630 ms]
       change: [-0.5004% -0.0402% +0.4296%] (p = 0.89 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) low mild
2 (2.00%) high mild
7 (7.00%) high severe

1 streams of 1 bytes/multistream: Change within noise threshold.
       time:   [71.852 µs 72.081 µs 72.312 µs]
       change: [-0.9270% -0.4764% -0.0506%] (p = 0.04 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1000 streams of 1 bytes/multistream: No change in performance detected.
       time:   [25.265 ms 25.303 ms 25.342 ms]
       change: [-0.3530% -0.1416% +0.0769%] (p = 0.20 > 0.05)
10000 streams of 1 bytes/multistream: Change within noise threshold.
       time:   [1.6916 s 1.6933 s 1.6951 s]
       change: [-0.3638% -0.2027% -0.0508%] (p = 0.01 < 0.05)

Found 24 outliers among 100 measurements (24.00%)
15 (15.00%) low mild
2 (2.00%) high mild
7 (7.00%) high severe

1 streams of 1000 bytes/multistream: No change in performance detected.
       time:   [74.126 µs 74.780 µs 75.857 µs]
       change: [-1.1264% +0.6459% +2.4817%] (p = 0.55 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

100 streams of 1000 bytes/multistream: No change in performance detected.
       time:   [3.3708 ms 3.3773 ms 3.3843 ms]
       change: [-0.5675% -0.2777% -0.0016%] (p = 0.06 > 0.05)

Found 22 outliers among 100 measurements (22.00%)
22 (22.00%) high severe

1000 streams of 1000 bytes/multistream: Change within noise threshold.
       time:   [143.51 ms 143.59 ms 143.66 ms]
       change: [-0.1719% -0.0942% -0.0186%] (p = 0.02 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [94.733 ns 95.083 ns 95.449 ns]
       change: [-0.4574% +0.0522% +0.6243%] (p = 0.85 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
8 (8.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [112.61 ns 112.86 ns 113.14 ns]
       change: [-0.4355% +0.6807% +2.4886%] (p = 0.50 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) low mild
1 (1.00%) high mild
10 (10.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [112.29 ns 112.82 ns 113.43 ns]
       change: [-0.2701% +0.1944% +0.6765%] (p = 0.42 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
3 (3.00%) low severe
1 (1.00%) low mild
3 (3.00%) high mild
9 (9.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [92.916 ns 93.396 ns 93.955 ns]
       change: [-1.4781% -0.1426% +1.3713%] (p = 0.86 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [116.42 ms 116.47 ms 116.53 ms]
       change: [-0.5098% -0.4476% -0.3816%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
1 (1.00%) low severe
4 (4.00%) low mild
9 (9.00%) high mild
1 (1.00%) high severe

SentPackets::take_ranges: No change in performance detected.
       time:   [8.2719 µs 8.5577 µs 8.8226 µs]
       change: [-5.8468% -3.0141% +0.2053%] (p = 0.06 > 0.05)

Found 22 outliers among 100 measurements (22.00%)
9 (9.00%) low severe
10 (10.00%) low mild
3 (3.00%) high mild

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [35.603 ms 35.666 ms 35.729 ms]
       change: [-0.7332% -0.4812% -0.2225%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [36.196 ms 36.291 ms 36.386 ms]
       change: [-1.4413% -1.0436% -0.6508%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [35.552 ms 35.598 ms 35.645 ms]
       change: [+0.0292% +0.1958% +0.3653%] (p = 0.03 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [37.214 ms 37.269 ms 37.323 ms]
       change: [+0.1719% +0.3923% +0.6137%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

Client/server transfer results

Performance differences relative to 28c0ea7.

Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.

Client Server CC Pacing Mean ± σ Min Max MiB/s ± σ Δ main Δ main
neqo neqo reno on 333.4 ± 34.6 306.9 488.1 96.0 ± 0.9 11.3 3.5%
neqo neqo reno 360.2 ± 118.1 302.3 899.5 88.8 ± 0.3 -7.6 -2.1%
neqo neqo cubic on 331.4 ± 21.1 305.6 374.4 96.5 ± 1.5 -8.8 -2.6%
neqo neqo cubic 332.3 ± 24.7 302.6 408.3 96.3 ± 1.3 -7.4 -2.2%
google neqo reno on 768.8 ± 89.3 550.0 905.7 41.6 ± 0.4 -5.3 -0.7%
google neqo reno 768.2 ± 94.9 565.4 1017.8 41.7 ± 0.3 -4.0 -0.5%
google neqo cubic on 765.9 ± 81.2 598.0 898.4 41.8 ± 0.4 -2.3 -0.3%
google neqo cubic 773.4 ± 96.3 558.8 1008.5 41.4 ± 0.3 7.8 1.0%
google google 575.9 ± 48.0 549.4 819.5 55.6 ± 0.7 -6.0 -1.0%
neqo msquic reno on 269.9 ± 33.9 243.7 415.9 118.6 ± 0.9 -6.4 -2.3%
neqo msquic reno 267.6 ± 30.3 241.0 405.1 119.6 ± 1.1 -7.7 -2.8%
neqo msquic cubic on 265.1 ± 14.5 244.7 296.8 120.7 ± 2.2 -9.4 -3.4%
neqo msquic cubic 266.8 ± 29.6 243.8 411.5 119.9 ± 1.1 -5.8 -2.1%
msquic msquic 170.0 ± 18.3 147.9 221.6 188.2 ± 1.7 -14.7 -8.0%

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant