Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin google-quiche until main compiles again #2573

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

larseggert
Copy link
Collaborator

Should fix the CI failures of the bencher.

Should fix the CI failures of the bencher.
Copy link

github-actions bot commented Apr 8, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 00646f0.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@larseggert larseggert added this pull request to the merge queue Apr 8, 2025
Copy link

github-actions bot commented Apr 8, 2025

Benchmark results

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client:
       time:   [736.52 ms 740.94 ms 745.37 ms]
       thrpt:  [134.16 MiB/s 134.96 MiB/s 135.77 MiB/s]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client:
       time:   [349.51 ms 350.99 ms 352.51 ms]
       thrpt:  [28.368 Kelem/s 28.491 Kelem/s 28.611 Kelem/s]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client:
       time:   [24.988 ms 25.144 ms 25.303 ms]
       thrpt:  [39.521  elem/s 39.772  elem/s 40.019  elem/s]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client:
       time:   [1.8764 s 1.8974 s 1.9195 s]
       thrpt:  [52.096 MiB/s 52.703 MiB/s 53.294 MiB/s]
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild
decode 4096 bytes, mask ff:
       time:   [12.087 µs 12.128 µs 12.175 µs]
Found 16 outliers among 100 measurements (16.00%)
  4 (4.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  9 (9.00%) high severe
decode 1048576 bytes, mask ff:
       time:   [3.1317 ms 3.1416 ms 3.1531 ms]
Found 10 outliers among 100 measurements (10.00%)
  10 (10.00%) high severe
decode 4096 bytes, mask 7f:
       time:   [20.189 µs 20.250 µs 20.313 µs]
Found 20 outliers among 100 measurements (20.00%)
  2 (2.00%) low severe
  1 (1.00%) low mild
  3 (3.00%) high mild
  14 (14.00%) high severe
decode 1048576 bytes, mask 7f:
       time:   [5.2453 ms 5.2567 ms 5.2696 ms]
Found 12 outliers among 100 measurements (12.00%)
  12 (12.00%) high severe
decode 4096 bytes, mask 3f:
       time:   [7.0082 µs 7.0307 µs 7.0595 µs]
Found 12 outliers among 100 measurements (12.00%)
  5 (5.00%) low severe
  2 (2.00%) low mild
  1 (1.00%) high mild
  4 (4.00%) high severe
decode 1048576 bytes, mask 3f:
       time:   [1.7918 ms 1.7975 ms 1.8046 ms]
Found 6 outliers among 100 measurements (6.00%)
  6 (6.00%) high severe
1 streams of 1 bytes/multistream:
       time:   [72.753 µs 72.970 µs 73.192 µs]
1000 streams of 1 bytes/multistream:
       time:   [24.804 ms 24.838 ms 24.874 ms]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
10000 streams of 1 bytes/multistream:
       time:   [1.6841 s 1.6857 s 1.6873 s]
Found 18 outliers among 100 measurements (18.00%)
  2 (2.00%) low severe
  9 (9.00%) low mild
  2 (2.00%) high mild
  5 (5.00%) high severe
1 streams of 1000 bytes/multistream:
       time:   [74.348 µs 74.641 µs 74.936 µs]
100 streams of 1000 bytes/multistream:
       time:   [3.3648 ms 3.3715 ms 3.3787 ms]
Found 23 outliers among 100 measurements (23.00%)
  23 (23.00%) high severe
1000 streams of 1000 bytes/multistream:
       time:   [142.70 ms 142.78 ms 142.85 ms]
coalesce_acked_from_zero 1+1 entries:
       time:   [94.915 ns 95.321 ns 95.744 ns]
Found 15 outliers among 100 measurements (15.00%)
  10 (10.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 3+1 entries:
       time:   [112.85 ns 113.22 ns 113.63 ns]
Found 15 outliers among 100 measurements (15.00%)
  2 (2.00%) low mild
  1 (1.00%) high mild
  12 (12.00%) high severe
coalesce_acked_from_zero 10+1 entries:
       time:   [112.31 ns 112.74 ns 113.26 ns]
Found 19 outliers among 100 measurements (19.00%)
  7 (7.00%) low severe
  2 (2.00%) low mild
  3 (3.00%) high mild
  7 (7.00%) high severe
coalesce_acked_from_zero 1000+1 entries:
       time:   [93.627 ns 94.169 ns 94.812 ns]
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) high mild
  3 (3.00%) high severe
RxStreamOrderer::inbound_frame():
       time:   [115.69 ms 115.74 ms 115.80 ms]
Found 17 outliers among 100 measurements (17.00%)
  2 (2.00%) low severe
  5 (5.00%) low mild
  10 (10.00%) high mild
SentPackets::take_ranges:
       time:   [8.2317 µs 8.4821 µs 8.7134 µs]
Found 21 outliers among 100 measurements (21.00%)
  2 (2.00%) low severe
  17 (17.00%) low mild
  1 (1.00%) high mild
  1 (1.00%) high severe
transfer/pacing-false/varying-seeds:
       time:   [35.802 ms 35.869 ms 35.935 ms]
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
transfer/pacing-true/varying-seeds:
       time:   [36.989 ms 37.099 ms 37.209 ms]
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
transfer/pacing-false/same-seed:
       time:   [35.906 ms 35.954 ms 36.002 ms]
transfer/pacing-true/same-seed:
       time:   [37.446 ms 37.505 ms 37.563 ms]

Client/server transfer results

Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.

Client Server CC Pacing Mean ± σ Min Max MiB/s ± σ Δ main Δ main
neqo neqo reno on 332.7 ± 38.6 298.0 476.7
neqo neqo reno 362.5 ± 131.6 294.3 946.7
neqo neqo cubic on 329.2 ± 36.0 301.9 492.8
neqo neqo cubic 332.3 ± 47.1 297.8 502.9
google neqo reno on 765.0 ± 76.1 571.4 828.2
google neqo reno 764.1 ± 86.5 569.6 896.1
google neqo cubic on 762.6 ± 85.0 557.3 932.0
google neqo cubic 766.0 ± 85.5 566.1 965.2
google google 569.9 ± 20.2 547.0 649.7
neqo msquic reno on 278.6 ± 51.9 244.5 486.2
neqo msquic reno 264.3 ± 16.3 245.6 318.5
neqo msquic cubic on 268.2 ± 33.1 243.9 428.0
neqo msquic cubic 266.8 ± 14.7 242.7 307.8
msquic msquic 179.2 ± 36.2 148.1 322.6

⬇️ Download logs

Merged via the queue into mozilla:main with commit c1679d8 Apr 8, 2025
83 of 84 checks passed
@larseggert larseggert deleted the fix-pin-google-quiche branch April 8, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants