Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Cargo.lock): update to qlog v0.15.2 #2572

Merged
merged 1 commit into from
Apr 8, 2025
Merged

chore(Cargo.lock): update to qlog v0.15.2 #2572

merged 1 commit into from
Apr 8, 2025

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Apr 8, 2025

qlog v0.15.1 introduced various unnecessary dependencies. See Cargo.lock changes in #2512 and full analysis in cloudflare/quiche#2005.

This commit updates Neqo Cargo.lock to use qlog v0.15.2, effectively removing all the unnecessary dependencies.

Given that Neqo builds with qlog v0.15.1 just fine, this commit updates the Cargo.lock only. Also note that this commit is not required for qlog v0.15.2 to land in mozilla-central.

➜  neqo git:(main) cargo update -p qlog --precise 0.15.2
    Updating crates.io index
    Removing android-tzdata v0.1.1
    Removing android_system_properties v0.1.5
    Removing base64 v0.22.1
    Removing bumpalo v3.17.0
    Removing chrono v0.4.40
    Removing core-foundation-sys v0.8.7
    Removing deranged v0.4.0
    Removing hashbrown v0.12.3
    Removing iana-time-zone v0.1.61
    Removing iana-time-zone-haiku v0.1.2
    Removing indexmap v1.9.3
    Removing js-sys v0.3.77
    Removing num-conv v0.1.0
    Removing powerfmt v0.2.0
    Updating qlog v0.15.1 -> v0.15.2
    Removing time v0.3.40
    Removing time-core v0.1.4
    Removing time-macros v0.2.21
    Removing wasm-bindgen v0.2.100
    Removing wasm-bindgen-backend v0.2.100
    Removing wasm-bindgen-macro v0.2.100
    Removing wasm-bindgen-macro-support v0.2.100
    Removing wasm-bindgen-shared v0.2.100
    Removing windows-core v0.52.0
    Removing windows-link v0.1.1

@mxinden
chore(Cargo.lock): update to qlog v0.15.2
f644522 
`qlog` `v0.15.1` introduced various unnecessary dependencies. See
`Cargo.lock` changes in mozilla#2512 and
full analysis in cloudflare/quiche#2005.

This commit updates Neqo `Cargo.lock` to use `qlog` `v0.15.2`,
effectively removing all the unnecessary dependencies.

Given that Neqo builds with `qlog` `v0.15.1` just fine, this commit
updates the `Cargo.lock` only. Also note that this commit is not
required for `qlog` `v0.15.2` to land in mozilla-central.
@larseggert larseggert enabled auto-merge April 8, 2025 14:00
@larseggert larseggert added this pull request to the merge queue Apr 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 00646f0.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Merged via the queue into mozilla:main with commit 1fc699d Apr 8, 2025
78 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larseggert larseggert larseggert approved these changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @larseggert