chore(Cargo.toml): require qlog v0.15.1 #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozilla#2512 bumped `qlog` to `v0.15.0`, but made use of features only available in `qlog` `v0.15.1`. Thus while using `qlog` `v0.15.0` would be allowed according to Neqo's root `Cargo.toml`, it would not compile. This commit increases the `qlog` requirement to `v0.15.1`.
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 00646f0. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
approved these changes
Apr 8, 2025
|
No worries. I didn't catch this in my review either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2512 bumped
qlogtov0.15.0, but made use of features only available inqlogv0.15.1. Thus while usingqlogv0.15.0would be allowed according to Neqo's rootCargo.toml, it would not compile.This commit increases the
qlogrequirement tov0.15.1.