build(deps): bump tokio from 1.39.2 to 1.43.1 in the cargo group #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
requested review from
KershawChang,
martinthomson,
larseggert and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to c1679d8. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
dependabot
bot
force-pushed
the
dependabot/cargo/cargo-8c74fa0cce
branch
from
98811c9 to
c56cc93
Compare
mxinden
approved these changes
Apr 8, 2025
dependabot
bot
force-pushed
the
dependabot/cargo/cargo-8c74fa0cce
branch
from
c56cc93 to
a604605
Compare
Bumps the cargo group with 1 update: [tokio](https://github.com/tokio-rs/tokio). Updates `tokio` from 1.39.2 to 1.43.1 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.39.2...tokio-1.43.1) --- updated-dependencies: - dependency-name: tokio dependency-version: 1.43.1 dependency-type: direct:production dependency-group: cargo ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/cargo/cargo-8c74fa0cce
branch
from
a604605 to
cda0202
Compare
|
@larseggert do you have an intuition how codecov thinks that this pull request has a -2.6% change in test coverage compared to
|
|
I don't. I wonder if we should revert the MC/DC stuff, it seems to lead to random noise like this. |
|
Thanks. Worth a try. For the record, I created #2575. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 115 115
Lines 37275 37275
Branches 37275 37275
=======================================
Hits 35616 35616
Misses 1651 1651
Partials 8 8
|
Benchmark resultsPerformance differences relative to 911ee9c. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [709.12 ms 713.13 ms 717.18 ms]
thrpt: [139.43 MiB/s 140.23 MiB/s 141.02 MiB/s]
change:
time: [-3.4262% -2.5569% -1.7289%] (p = 0.00 < 0.05)
thrpt: [+1.7593% +2.6240% +3.5478%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [350.57 ms 352.12 ms 353.67 ms]
thrpt: [28.275 Kelem/s 28.400 Kelem/s 28.525 Kelem/s]
change:
time: [+0.1946% +0.8111% +1.4121%] (p = 0.01 < 0.05)
thrpt: [-1.3924% -0.8046% -0.1942%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.065 ms 25.223 ms 25.387 ms]
thrpt: [39.390 elem/s 39.646 elem/s 39.897 elem/s]
change:
time: [-0.7505% +0.1914% +1.1397%] (p = 0.69 > 0.05)
thrpt: [-1.1269% -0.1911% +0.7562%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.8633 s 1.8798 s 1.8970 s]
thrpt: [52.714 MiB/s 53.196 MiB/s 53.669 MiB/s]
change:
time: [+1.9508% +3.6105% +5.3561%] (p = 0.00 < 0.05)
thrpt: [-5.0838% -3.4847% -1.9135%]
decode 4096 bytes, mask ff: Change within noise threshold. time: [11.980 µs 11.988 µs 12.001 µs]
change: [-1.6231% -1.0768% -0.3902%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.9497 ms 2.9558 ms 2.9636 ms]
change: [-6.3493% -5.9308% -5.5212%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: Change within noise threshold. time: [20.011 µs 20.061 µs 20.117 µs]
change: [-1.6841% -1.0549% -0.4583%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [4.7995 ms 4.8122 ms 4.8257 ms]
change: [-8.7289% -8.4062% -8.0698%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💚 Performance has improved. time: [6.3103 µs 6.3198 µs 6.3369 µs]
change: [-10.189% -9.7872% -9.3153%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [2.1512 ms 2.1583 ms 2.1667 ms]
change: [+19.321% +19.952% +20.588%] (p = 0.00 < 0.05)
1 streams of 1 bytes/multistream: No change in performance detected. time: [72.796 µs 73.015 µs 73.237 µs]
change: [-0.4554% -0.0615% +0.3549%] (p = 0.77 > 0.05)
1000 streams of 1 bytes/multistream: 💔 Performance has regressed. time: [25.286 ms 25.320 ms 25.354 ms]
change: [+1.6601% +1.8688% +2.0730%] (p = 0.00 < 0.05)
10000 streams of 1 bytes/multistream: 💔 Performance has regressed. time: [1.6999 s 1.7015 s 1.7031 s]
change: [+1.1394% +1.2814% +1.4316%] (p = 0.00 < 0.05)
1 streams of 1000 bytes/multistream: No change in performance detected. time: [74.471 µs 75.541 µs 77.043 µs]
change: [-2.9160% -0.2351% +2.5749%] (p = 0.87 > 0.05)
100 streams of 1000 bytes/multistream: No change in performance detected. time: [3.3779 ms 3.3842 ms 3.3910 ms]
change: [-0.1023% +0.1855% +0.4792%] (p = 0.19 > 0.05)
1000 streams of 1000 bytes/multistream: Change within noise threshold. time: [143.80 ms 143.87 ms 143.94 ms]
change: [+0.5853% +0.6579% +0.7281%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [94.772 ns 95.141 ns 95.524 ns]
change: [-1.1474% -0.3690% +0.3068%] (p = 0.35 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [112.55 ns 112.91 ns 113.29 ns]
change: [-0.9335% -0.4183% +0.0349%] (p = 0.11 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [111.84 ns 112.25 ns 112.74 ns]
change: [-1.2865% -0.8794% -0.4895%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.033 ns 93.463 ns 93.913 ns]
change: [-1.9624% -0.9926% +0.0206%] (p = 0.06 > 0.05)
RxStreamOrderer::inbound_frame(): 💔 Performance has regressed. time: [117.04 ms 117.09 ms 117.14 ms]
change: [+1.9292% +2.0017% +2.0734%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [8.3156 µs 8.5543 µs 8.7701 µs]
change: [-4.7915% -1.7543% +1.2616%] (p = 0.26 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [35.721 ms 35.790 ms 35.858 ms]
change: [-1.4005% -1.1234% -0.8582%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [36.483 ms 36.592 ms 36.700 ms]
change: [-1.1385% -0.7317% -0.3019%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [35.352 ms 35.396 ms 35.441 ms]
change: [-1.4171% -1.2522% -1.0778%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [36.806 ms 36.868 ms 36.930 ms]
change: [-1.6423% -1.4000% -1.1604%] (p = 0.00 < 0.05)
Client/server transfer resultsPerformance differences relative to 911ee9c. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the cargo group with 1 update: tokio.
Updates
tokiofrom 1.39.2 to 1.43.1Release notes
Sourced from tokio's releases.
... (truncated)
Commits
a7b658cchore: prepare Tokio v1.43.1 releasec1c8d10Merge remote-tracking branch 'origin/tokio-1.38.x' into forward-port-1.38.xaa303bcchore: prepare Tokio v1.38.2 release7b6ccb5chore: backport CI fixes4b174cesync: fix cloning value when receiving from broadcast channel5f3296dchore: prepare Tokio v1.43.0 (#7079)cc974a6chore: prepare tokio-macros v2.5.0 (#7078)15495fdmetrics: improve flexibility of H2Histogram Configuration (#6963)ad41834io: don't callset_lenbefore initializing vector inBlocking(#7054)bd3e857runtime: moveis_join_waker_setassertion inunset_waker(#7072)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.