chore(audit): ignore RUSTSEC-2025-0023 #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
RUSTSEC-2025-0023 discloses a vulnerability in Tokio: "Broadcast channel calls clone in parallel, but does not require `Sync`". https://rustsec.org/advisories/RUSTSEC-2025-0023 Tokio is only used in neqo-bin. neqo-bin does not make use of Tokio's broadcast channels. neqo-bin is not used by Firefox. All Tokio versions with a fix for RUSTSEC-2025-0023 require a libc version bump, i.e. require us to use a libc version other than what mozilla-central uses. Thus, instead of updating Tokio, this commit simply ignores the CVE.
|
CI failure due to #2422. |
larseggert
reviewed
Apr 7, 2025
larseggert
approved these changes
Apr 7, 2025
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUSTSEC-2025-0023 discloses a vulnerability in Tokio: "Broadcast channel calls clone in parallel, but does not require
Sync".https://rustsec.org/advisories/RUSTSEC-2025-0023
Tokio is only used in neqo-bin. neqo-bin does not make use of Tokio's broadcast channels. neqo-bin is not used by Firefox.
All Tokio versions with a fix for RUSTSEC-2025-0023 require a libc version bump, i.e. require us to use a libc version other than what mozilla-central uses.
Thus, instead of updating Tokio, this commit simply ignores the CVE.