Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Actually briefly run fuzzer and benches #2559

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

larseggert
Copy link
Collaborator

Because just building them can hide errors.

Because just building them can hide errors.
Copy link

github-actions bot commented Apr 4, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 182afed.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Apr 4, 2025

Benchmark results

Performance differences relative to 41036fc.

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [734.22 ms 738.45 ms 742.68 ms]
       thrpt:  [134.65 MiB/s 135.42 MiB/s 136.20 MiB/s]
change:
       time:   [-0.2199% +0.5646% +1.4077%] (p = 0.18 > 0.05)
       thrpt:  [-1.3881% -0.5614% +0.2203%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [348.23 ms 349.81 ms 351.37 ms]
       thrpt:  [28.460 Kelem/s 28.587 Kelem/s 28.716 Kelem/s]
change:
       time:   [-0.3455% +0.3043% +0.9673%] (p = 0.37 > 0.05)
       thrpt:  [-0.9580% -0.3034% +0.3467%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold.
       time:   [24.764 ms 24.914 ms 25.073 ms]
       thrpt:  [39.884  elem/s 40.138  elem/s 40.382  elem/s]
change:
       time:   [-1.8667% -0.9810% -0.0439%] (p = 0.04 < 0.05)
       thrpt:  [+0.0440% +0.9907% +1.9022%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.8332 s 1.8538 s 1.8755 s]
       thrpt:  [53.320 MiB/s 53.942 MiB/s 54.548 MiB/s]
change:
       time:   [-2.5457% -0.9930% +0.6250%] (p = 0.23 > 0.05)
       thrpt:  [-0.6211% +1.0030% +2.6122%]

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [12.076 µs 12.112 µs 12.156 µs]
       change: [-0.9586% -0.4679% -0.0154%] (p = 0.06 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
4 (4.00%) low severe
5 (5.00%) low mild
3 (3.00%) high mild
6 (6.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0808 ms 3.0906 ms 3.1020 ms]
       change: [-0.4618% +0.0349% +0.5469%] (p = 0.90 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
1 (1.00%) low mild
3 (3.00%) high mild
10 (10.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [20.142 µs 20.188 µs 20.242 µs]
       change: [-0.5397% -0.1359% +0.2516%] (p = 0.51 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
1 (1.00%) low severe
2 (2.00%) low mild
3 (3.00%) high mild
11 (11.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.2559 ms 5.2689 ms 5.2832 ms]
       change: [-0.0870% +0.2367% +0.5625%] (p = 0.16 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
16 (16.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [7.0161 µs 7.0453 µs 7.0807 µs]
       change: [-0.5715% -0.0592% +0.4234%] (p = 0.83 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
4 (4.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
6 (6.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.7924 ms 1.7992 ms 1.8063 ms]
       change: [-0.3719% +0.1185% +0.6042%] (p = 0.66 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high severe

1 streams of 1 bytes/multistream: No change in performance detected.
       time:   [73.931 µs 74.143 µs 74.359 µs]
       change: [-1.4358% +0.1039% +1.0639%] (p = 0.90 > 0.05)
1000 streams of 1 bytes/multistream: Change within noise threshold.
       time:   [25.442 ms 25.478 ms 25.514 ms]
       change: [+0.2240% +0.4361% +0.6441%] (p = 0.00 < 0.05)
10000 streams of 1 bytes/multistream: Change within noise threshold.
       time:   [1.7114 s 1.7130 s 1.7147 s]
       change: [+0.2057% +0.3543% +0.5034%] (p = 0.00 < 0.05)

Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
5 (5.00%) high mild

1 streams of 1000 bytes/multistream: No change in performance detected.
       time:   [75.365 µs 76.450 µs 77.968 µs]
       change: [-0.9164% +1.0766% +3.4559%] (p = 0.38 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe

100 streams of 1000 bytes/multistream: Change within noise threshold.
       time:   [3.4369 ms 3.4437 ms 3.4511 ms]
       change: [+0.2901% +0.5723% +0.8580%] (p = 0.00 < 0.05)

Found 19 outliers among 100 measurements (19.00%)
19 (19.00%) high severe

1000 streams of 1000 bytes/multistream: 💔 Performance has regressed.
       time:   [147.95 ms 148.02 ms 148.10 ms]
       change: [+2.7942% +2.8781% +2.9533%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [94.690 ns 95.054 ns 95.432 ns]
       change: [-2.6964% -0.8954% +0.3177%] (p = 0.32 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low mild
9 (9.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [112.43 ns 112.74 ns 113.08 ns]
       change: [-0.5025% -0.1864% +0.1152%] (p = 0.24 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low severe
2 (2.00%) low mild
3 (3.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [111.99 ns 112.38 ns 112.86 ns]
       change: [-0.5451% -0.1237% +0.3279%] (p = 0.57 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
3 (3.00%) low severe
4 (4.00%) low mild
9 (9.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [93.417 ns 93.861 ns 94.290 ns]
       change: [-0.9277% +0.1161% +1.1881%] (p = 0.83 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [115.21 ms 115.27 ms 115.33 ms]
       change: [-0.0282% +0.0399% +0.1091%] (p = 0.28 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
3 (3.00%) low severe
5 (5.00%) low mild
8 (8.00%) high mild
4 (4.00%) high severe

SentPackets::take_ranges: No change in performance detected.
       time:   [8.3458 µs 8.5898 µs 8.8137 µs]
       change: [-5.3496% -1.8959% +1.5433%] (p = 0.31 > 0.05)

Found 21 outliers among 100 measurements (21.00%)
9 (9.00%) low severe
9 (9.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [35.343 ms 35.407 ms 35.472 ms]
       change: [-0.4659% -0.1842% +0.0565%] (p = 0.18 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [36.385 ms 36.488 ms 36.592 ms]
       change: [+0.7656% +1.1567% +1.5457%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [35.304 ms 35.351 ms 35.399 ms]
       change: [+0.1283% +0.3161% +0.5102%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [37.035 ms 37.105 ms 37.175 ms]
       change: [+1.0307% +1.2910% +1.5392%] (p = 0.00 < 0.05)

Client/server transfer results

Performance differences relative to 41036fc.

Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.

Client Server CC Pacing Mean ± σ Min Max MiB/s ± σ Δ main Δ main
neqo neqo reno on 327.2 ± 44.4 294.3 476.6 97.8 ± 0.7 -6.1 -1.8%
neqo neqo reno 345.6 ± 65.4 294.9 572.5 92.6 ± 0.5 -14.2 -4.0%
neqo neqo cubic on 328.6 ± 40.8 296.9 499.6 97.4 ± 0.8 -8.9 -2.6%
neqo neqo cubic 331.1 ± 43.9 301.7 512.0 96.6 ± 0.7 -0.1 -0.0%
google neqo reno on 766.0 ± 94.4 560.6 1015.8 41.8 ± 0.3 4.4 0.6%
google neqo reno 759.1 ± 92.5 539.2 947.9 42.2 ± 0.3 -3.7 -0.5%
google neqo cubic on 763.0 ± 91.3 565.2 1012.9 41.9 ± 0.4 -10.2 -1.3%
google neqo cubic 765.0 ± 84.1 573.7 903.5 41.8 ± 0.4 5.8 0.8%
google google 571.4 ± 15.7 554.3 613.6 56.0 ± 2.0 -10.8 -1.9%
neqo msquic reno on 290.0 ± 87.5 243.1 646.1 110.3 ± 0.4 14.0 5.1%
neqo msquic reno 271.7 ± 33.2 243.4 419.2 117.8 ± 1.0 -8.0 -2.9%
neqo msquic cubic on 269.2 ± 35.7 245.0 442.2 118.9 ± 0.9 1.0 0.4%
neqo msquic cubic 273.6 ± 44.3 245.1 443.5 117.0 ± 0.7 5.9 2.2%
msquic msquic 179.9 ± 33.2 146.0 270.2 177.8 ± 1.0 -5.1 -2.8%

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Apr 7, 2025
Merged via the queue into mozilla:main with commit 1081ab0 Apr 7, 2025
83 of 84 checks passed
@larseggert larseggert deleted the ci-run-fuzz-bench branch April 7, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants