refactor(bin/bench): fix typo %s/resp/req #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
larseggert
approved these changes
Mar 31, 2025
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to cce6f77. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [713.96 ms 718.73 ms 723.42 ms]
thrpt: [138.23 MiB/s 139.14 MiB/s 140.06 MiB/s]
change:
time: [+0.3294% +1.2598% +2.2298%] (p = 0.01 < 0.05)
thrpt: [-2.1811% -1.2442% -0.3283%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [347.84 ms 349.32 ms 350.79 ms]
thrpt: [28.507 Kelem/s 28.627 Kelem/s 28.748 Kelem/s]
change:
time: [-0.6313% +0.0205% +0.6813%] (p = 0.95 > 0.05)
thrpt: [-0.6767% -0.0205% +0.6353%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [24.878 ms 25.027 ms 25.183 ms]
thrpt: [39.710 elem/s 39.957 elem/s 40.196 elem/s]
change:
time: [-0.2648% +0.5621% +1.3537%] (p = 0.19 > 0.05)
thrpt: [-1.3356% -0.5590% +0.2655%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: time: [1.9404 s 1.9583 s 1.9761 s]
thrpt: [50.605 MiB/s 51.065 MiB/s 51.535 MiB/s]decode 4096 bytes, mask ff: No change in performance detected. time: [11.981 µs 12.012 µs 12.050 µs]
change: [-0.7059% -0.3165% +0.0553%] (p = 0.11 > 0.05)
decode 1048576 bytes, mask ff: Change within noise threshold. time: [2.9578 ms 2.9694 ms 2.9825 ms]
change: [+0.0324% +0.5231% +0.9733%] (p = 0.05 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.022 µs 20.077 µs 20.137 µs]
change: [-0.4480% +0.0467% +0.5551%] (p = 0.87 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.7899 ms 4.8014 ms 4.8146 ms]
change: [-0.4588% -0.0953% +0.2760%] (p = 0.62 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.3147 µs 6.3403 µs 6.3724 µs]
change: [-1.5243% -0.7158% +0.0479%] (p = 0.08 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [2.1495 ms 2.1566 ms 2.1649 ms]
change: [-0.2974% +0.1082% +0.6217%] (p = 0.67 > 0.05)
1 streams of 1 bytes/multistream: No change in performance detected. time: [70.812 µs 71.471 µs 72.579 µs]
change: [-0.9981% +0.0230% +1.5823%] (p = 0.98 > 0.05)
1000 streams of 1 bytes/multistream: No change in performance detected. time: [25.340 ms 25.378 ms 25.417 ms]
change: [-0.2324% -0.0185% +0.1968%] (p = 0.87 > 0.05)
10000 streams of 1 bytes/multistream: Change within noise threshold. time: [1.6994 s 1.7011 s 1.7029 s]
change: [-0.4567% -0.3144% -0.1712%] (p = 0.00 < 0.05)
1 streams of 1000 bytes/multistream: No change in performance detected. time: [72.987 µs 73.242 µs 73.495 µs]
change: [-2.5852% -0.5799% +0.9763%] (p = 0.61 > 0.05)
100 streams of 1000 bytes/multistream: No change in performance detected. time: [3.3945 ms 3.4010 ms 3.4079 ms]
change: [-0.2837% -0.0127% +0.2453%] (p = 0.93 > 0.05)
1000 streams of 1000 bytes/multistream: No change in performance detected. time: [145.51 ms 145.59 ms 145.67 ms]
change: [-0.1009% -0.0273% +0.0462%] (p = 0.47 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [94.808 ns 95.089 ns 95.372 ns]
change: [-0.4676% -0.0116% +0.5165%] (p = 0.96 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [113.12 ns 113.49 ns 113.90 ns]
change: [-0.4882% -0.0916% +0.3362%] (p = 0.66 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [112.60 ns 113.05 ns 113.59 ns]
change: [-0.5271% +0.0839% +0.6847%] (p = 0.79 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.314 ns 93.700 ns 94.105 ns]
change: [-5.7626% -1.3134% +2.7515%] (p = 0.61 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [117.20 ms 117.25 ms 117.31 ms]
change: [+0.4570% +0.5218% +0.5892%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [8.1418 µs 8.4090 µs 8.6459 µs]
change: [-5.0104% -1.1134% +3.0649%] (p = 0.61 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [35.268 ms 35.331 ms 35.395 ms]
change: [-0.1890% +0.0790% +0.3465%] (p = 0.57 > 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [35.760 ms 35.818 ms 35.876 ms]
change: [+0.9866% +1.2140% +1.4510%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [35.217 ms 35.277 ms 35.336 ms]
change: [-0.7178% -0.4983% -0.2733%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [35.597 ms 35.649 ms 35.700 ms]
change: [-0.4648% -0.2462% -0.0499%] (p = 0.02 < 0.05)
Client/server transfer resultsPerformance differences relative to cce6f77. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in #2538.