refactor(transport/recovery): use PacketNumberSpace Debug in qdebug #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple change to improve debug level log message: ``` diff - 0.002 DEBUG [LossRecovery] PTO timer fired for in + 0.006 DEBUG [LossRecovery] PTO timer fired for Initial ```
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to f95b6c3. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to f95b6c3. decode 4096 bytes, mask ff: No change in performance detected. time: [11.814 µs 11.842 µs 11.875 µs]
change: [-0.7034% -0.2643% +0.0633%] (p = 0.20 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0680 ms 3.0773 ms 3.0884 ms]
change: [-0.4719% +0.0100% +0.4760%] (p = 0.94 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.749 µs 19.788 µs 19.834 µs]
change: [-0.3726% -0.0174% +0.3237%] (p = 0.93 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1522 ms 5.1646 ms 5.1779 ms]
change: [-0.1892% +0.1580% +0.4914%] (p = 0.37 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.8720 µs 6.8958 µs 6.9264 µs]
change: [-0.2171% +0.7199% +2.2849%] (p = 0.35 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7537 ms 1.7579 ms 1.7635 ms]
change: [-0.6392% -0.1692% +0.3036%] (p = 0.50 > 0.05)
1 streams of 1 bytes/multistream: No change in performance detected. time: [69.666 µs 70.231 µs 71.258 µs]
change: [-2.0081% -0.0931% +1.9803%] (p = 0.89 > 0.05)
1000 streams of 1 bytes/multistream: Change within noise threshold. time: [24.471 ms 24.507 ms 24.544 ms]
change: [-0.4704% -0.2470% -0.0283%] (p = 0.03 < 0.05)
10000 streams of 1 bytes/multistream: Change within noise threshold. time: [1.6473 s 1.6489 s 1.6506 s]
change: [+0.1206% +0.2679% +0.4097%] (p = 0.00 < 0.05)
1 streams of 1000 bytes/multistream: No change in performance detected. time: [71.347 µs 71.911 µs 72.930 µs]
change: [-3.1197% -0.7141% +1.3480%] (p = 0.58 > 0.05)
100 streams of 1000 bytes/multistream: No change in performance detected. time: [3.2515 ms 3.2578 ms 3.2646 ms]
change: [-0.2021% +0.0875% +0.3814%] (p = 0.56 > 0.05)
1000 streams of 1000 bytes/multistream: No change in performance detected. time: [138.20 ms 138.27 ms 138.35 ms]
change: [-0.0585% +0.0187% +0.0995%] (p = 0.64 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [92.479 ns 92.777 ns 93.076 ns]
change: [-0.7955% -0.2319% +0.2901%] (p = 0.42 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [110.31 ns 110.67 ns 111.05 ns]
change: [-0.3543% +0.0482% +0.4322%] (p = 0.81 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [110.26 ns 110.83 ns 111.47 ns]
change: [+0.0005% +0.4942% +1.0897%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [91.201 ns 91.253 ns 91.319 ns]
change: [-1.3677% -0.5438% +0.2358%] (p = 0.21 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [115.77 ms 115.82 ms 115.87 ms]
change: [-0.0202% +0.0406% +0.1002%] (p = 0.19 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.3423 µs 5.5566 µs 5.7969 µs]
change: [-3.4790% -0.1832% +3.1267%] (p = 0.91 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [34.417 ms 34.479 ms 34.542 ms]
change: [-0.1867% +0.0835% +0.3550%] (p = 0.55 > 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [34.897 ms 34.952 ms 35.008 ms]
change: [+0.7422% +0.9698% +1.1754%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.644 ms 34.693 ms 34.744 ms]
change: [+0.7472% +0.9458% +1.1498%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [34.855 ms 34.911 ms 34.967 ms]
change: [+0.5429% +0.7843% +1.0343%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [2.2277 s 2.2346 s 2.2416 s]
thrpt: [44.611 MiB/s 44.750 MiB/s 44.890 MiB/s]
change:
time: [-0.2860% +0.1884% +0.6383%] (p = 0.42 > 0.05)
thrpt: [-0.6343% -0.1880% +0.2868%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [389.69 ms 391.75 ms 393.82 ms]
thrpt: [25.393 Kelem/s 25.527 Kelem/s 25.661 Kelem/s]
change:
time: [-0.8579% -0.1351% +0.6214%] (p = 0.73 > 0.05)
thrpt: [-0.6176% +0.1353% +0.8653%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: 💔 Performance has regressed. time: [29.399 ms 30.211 ms 31.015 ms]
thrpt: [32.243 elem/s 33.100 elem/s 34.015 elem/s]
change:
time: [+5.4095% +9.2634% +13.154%] (p = 0.00 < 0.05)
thrpt: [-11.625% -8.4781% -5.1319%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [3.5055 s 3.5276 s 3.5503 s]
thrpt: [28.166 MiB/s 28.348 MiB/s 28.526 MiB/s]
change:
time: [+8.8893% +9.8561% +10.848%] (p = 0.00 < 0.05)
thrpt: [-9.7863% -8.9718% -8.1636%]
Client/server transfer resultsPerformance differences relative to f95b6c3. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
larseggert
approved these changes
Mar 24, 2025
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Mar 27, 2025
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to improve debug level log message:
Previously it was not obvious to me that "in" meant "Initial" packet number space.