Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx and haproxy QNS tests broken #2566

Closed
larseggert opened this issue Apr 7, 2025 · 0 comments · Fixed by #2568
Closed

nginx and haproxy QNS tests broken #2566

larseggert opened this issue Apr 7, 2025 · 0 comments · Fixed by #2568

Comments

@larseggert
Copy link
Collaborator

git bisect says it was 41036fc. Need to figure out why & fix it.
larseggert added a commit to larseggert/neqo that referenced this issue Apr 7, 2025
@larseggert
fix: Fix QNS test errors with nginx
533bdd6 
And hopefully `haproxy`.

The old code caused ACK-ECN frames to be sent that had all-zero counts, which I don't think is a violation of the RFC, but we still shouldn't do.

Fixes mozilla#2566.
This was referenced Apr 7, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2025
@larseggert
fix: Fix QNS test errors with nginx (#2568)
0a356af 
* fix: Fix QNS test errors with `nginx`

And hopefully `haproxy`.

The old code caused ACK-ECN frames to be sent that had all-zero counts, which I don't think is a violation of the RFC, but we still shouldn't do.

Fixes #2566.

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix QNS test errors with nginx larseggert/neqo
1 participant
@larseggert