Update & simplify message data model #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #38, and will need a rebase after that's merged. Actual diff here is
reorg-paths...simpler-messages
.This applies the following upstream changes made to the MF2 data model:
Expression.annotation
is renamed asExpression.function
Going further from there, the message data model is also made more ergonomic:
SelectMessage
, as at least one is needed for the selector.(name, expression)
tuples.SelectMessage.selectors
is a tuple, not a list.FunctionAnnotation
is flattened intoExpression.function
andExpression.options
.As far as I can tell, no external users should be impacted by these changes.