Skip to content

disable manual deploys from tagging images with full commit SHA #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

cmharlow
Copy link

Jira: https://mozilla-hub.atlassian.net/browse/SE-2508

What this PR does:

  • disables tagging of manual delivery pipeline-generated Docker images with the full Commit SHA
  • images tagged with full commit SHA are limited to use by Gitflow-automated stage & production images, so only images that have gone through stage are promoted to production
  • This also means you can run manual delivery pipeline only for dev & stage environments, but you cannot run it for prod / none of the images from those pipelines will ever be looked up for promotion to prod.

@cmharlow cmharlow requested review from smarnach and a team August 30, 2021 17:22
Copy link

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels odd to me, and there's definitely some aspect here that I don't understand. In my opinion it should always be safe to tag images with git hashes. If these images get accidentally promoted to prod, then we have a problem elsewhere. Maybe we can discuss this in person tomorrow.

@cmharlow
Copy link
Author

cmharlow commented Sep 1, 2021

@smarnach pushed up changes discussed this AM - take a look & let me know what you think. I'd like to test it too while we have the prod flux disabled so we can see if the images are doing what we want.

wrt pinning the plugin versions, they're all on commits that don't match releases or branches unfortunately, so i'll need to add quite a bit of more code in the yaml to set that up. Not sure we want to do that right away or not, so I just at least captured current prod's plugins' commits.

Copy link

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cmharlow cmharlow merged commit 0bb38f7 into master Sep 1, 2021
@cmharlow cmharlow deleted the SE-2508 branch September 1, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants