ROS Parameter for service call timeout for ros_control controllers (backport #3419)

[mergify]

Description

Added a new ROS parameter controller_service_call_timeout for the ROS control interface managers, which can be specified in the moveit_controller yaml configuration file. I have tested it out using the https://github.com/moveit/moveit_resources/tree/ros2/dual_arm_panda_moveit_config example moveit configuration by trying out the following values for the parameter in the moveit_controllers.yaml:

controller_service_call_timeout: 0.00001 : Controllers did not connect
controller_service_call_timeout: 1.0 : Controllers connected and path planning could be executed

Closes issue #3405

Checklist

• Required by CI: Code is auto formatted using clang-format
• Extend the tutorials / documentation reference
• Document API changes relevant to the user in the MIGRATION.md notes
• Create tests, which fail without this PR reference
• Include a screenshot if changing a GUI
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

---

This is an automatic backport of pull request #3419 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 64e934f has failed:

On branch mergify/bp/humble/pr-3419
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 64e934ff4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_plugins/moveit_ros_control_interface/README.md
	both modified:   moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[sea-bass]

@ashwinsnambiar if you would like to resolve these conflicts for a Humble backport, it would be appreciated. It also doesn't really need a backport, though, so up to you!

[ashwinsnambiar]

Sorry for getting back late. I have made the necessary changes for the backport. Shall I create a new PR for that? @sea-bass

[sea-bass]

I have made necessary changes for the backport. Shall I create a new PR for that? @sea-bass

Yes -- easiest thing would be to just make a PR that targets this branch with the fixes. Else, a new PR altogether targeting Humble is fine too.

[ashwinsnambiar]

I have made a new PR #3458 targeting this branch with the fixes.

[sea-bass]

Thanks @ashwinsnambiar !

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.95%. Comparing base (85dd2cf) to head (8e22ed4).
Report is 1 commits behind head on humble.

Files with missing lines	Patch %	Lines
...ontrol_interface/src/controller_manager_plugin.cpp	88.89%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           humble    #3432      +/-   ##
==========================================
+ Coverage   50.94%   50.95%   +0.01%     
==========================================
  Files         390      390              
  Lines       32512    32520       +8     
==========================================
+ Hits        16560    16566       +6     
- Misses      15952    15954       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.