Skip to content

Remove source builds of geometric_shapes and srdfdom #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2025

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jan 12, 2025

Description

We had added these a few months back to circumvent some breakages, but this should no longer be needed.

Q: Should we backport this to Jazzy? Because if so, srdfdom there is at 2.0.5 and not 2.0.7, so I think we may need to first release to there. But I also forget whether the srdfdom version was actually a problem in Jazzy, or it was just Rolling. I guess it's worth just testing the backport?

(self-answer): I just pushed srdfdom 2.0.7 releases to humble and jazzy on rosdistro.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass added the backport-jazzy Mergify label that triggers a PR backport to Jazzy label Jan 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.13%. Comparing base (7284d36) to head (fd7751a).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   45.88%   42.13%   -3.75%     
==========================================
  Files         717      704      -13     
  Lines       62575    57809    -4766     
  Branches     7565     7566       +1     
==========================================
- Hits        28706    24351    -4355     
+ Misses      33703    31859    -1844     
- Partials      166     1599    +1433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sea-bass
Copy link
Contributor Author

sea-bass commented Jan 12, 2025

Bleh. This error seems familiar but I forget what it was.

geninfo: ERROR: unable to open /opt/ros/rolling/include/srdfdom/srdfdom/model.h: No such file or directory
  	(use "geninfo --ignore-errors source ..." to bypass this error)

Update: Ended up ignoring it, and it makes CI pass, but unclear whether this is right.

@sea-bass
Copy link
Contributor Author

Maybe we hold off on this until moveit/geometric_shapes#258 is released as well?

@sea-bass
Copy link
Contributor Author

sea-bass commented Feb 7, 2025

Bleh. This error seems familiar but I forget what it was.

geninfo: ERROR: unable to open /opt/ros/rolling/include/srdfdom/srdfdom/model.h: No such file or directory
  	(use "geninfo --ignore-errors source ..." to bypass this error)

Update: Ended up ignoring it, and it makes CI pass, but unclear whether this is right.

This is annoying. Seems that the coverage tool has analyzed files in geometric_shapes that were previously cloned via vcs, but removing this is what causes the issue.

Is there a better way to clear out this state that doesn't lead to ignoring all missing source code errors?

@sea-bass sea-bass added the persistent Allows issues to remain open without automatic stalling and closing. label Mar 19, 2025
@mikeferguson
Copy link
Contributor

Since it's the code coverage tool, I think the only way to reset the cache of what it is comparing against is to merge the PR (when we merge, it will run the CI, and then that is the new baseline that all PRs are compared against)

@sea-bass sea-bass merged commit eb8bfdc into main Mar 19, 2025
12 of 14 checks passed
@sea-bass sea-bass deleted the remove-geometric-shapes-srdfdom-repos-file branch March 19, 2025 12:36
mergify bot pushed a commit that referenced this pull request Mar 19, 2025
sea-bass added a commit that referenced this pull request Mar 19, 2025
(cherry picked from commit eb8bfdc)

Co-authored-by: Sebastian Castro <[email protected]>
sussybot5258 pushed a commit to GreyCatAI/moveit2 that referenced this pull request Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Mergify label that triggers a PR backport to Jazzy persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants