Skip to content

[Certora] Simplify summarization of mulDiv and price #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 2, 2025
Merged

[Certora] Simplify summarization of mulDiv and price #722

merged 8 commits into from
Mar 2, 2025

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Feb 21, 2025 •
edited
Loading

This PR:

  • removes summarization of mulDiv that was not needed
  • simplifies the summarization of the oracle, that was essentially always used as a constant
  • removes the assumption about summaryMulDiv in specs

@QGarchery QGarchery self-assigned this Feb 21, 2025
@MathisGD MathisGD changed the title Simplify summarization of mulDiv and price [Certora] Simplify summarization of mulDiv and price Feb 21, 2025
QGarchery
QGarchery commented Feb 25, 2025
View reviewed changes
@QGarchery QGarchery marked this pull request as ready for review February 25, 2025 16:08
colin-morpho
colin-morpho previously approved these changes Feb 25, 2025
View reviewed changes
@MathisGD MathisGD merged commit a23260a into main Mar 2, 2025
17 checks passed
@MathisGD MathisGD deleted the certora/simplify-summary branch March 2, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@colin-morpho colin-morpho colin-morpho approved these changes

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QGarchery @MathisGD @colin-morpho