Skip to content

Added a port for firefox #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Added a port for firefox #101

merged 1 commit into from
Feb 8, 2021

Conversation

abrahamparayil
Copy link
Contributor

No description provided.

@vanillajonathan
Copy link

Humble Gruvbox by Mekeor Melire seems to be the most popular with 300+ users.

Searching on AMO returns plenty of results.
https://addons.mozilla.org/en-US/firefox/search/?q=gruvbox

@abrahamparayil
Copy link
Contributor Author

abrahamparayil commented Feb 8, 2021

Humble Gruvbox by Mekeor Melire seems to be the most popular with 300+ users.

Searching on AMO returns plenty of results.
https://addons.mozilla.org/en-US/firefox/search/?q=gruvbox

@vanillajonathan
Well with all due respect my port isn't technically inferior to Mekeor Melire's and I opened a PR with the intention of listing my port here while that person or the others listed in the search didn't. So I don't understand why the existence that port prevents my port from being listed here.

@morhetz morhetz merged commit c143408 into morhetz:master Feb 8, 2021
@vanillajonathan
Copy link

@avronr
I didn't imply that your work was in any way inferior, nor that your port shouldn't be included in the listing. I apologize if I came off that way. My intention was just to bring forward the fact that there existed a port for Firefox on AMO. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants