Skip to content

chore: Upgrade to eslint9 #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025
Merged

Conversation

bingenito
Copy link
Member

  • Introduced ESLint9 configuration file with rules and license header enforcement.
  • Added license header to missing files via lint:fix
  • Configured ESLint to ignore specific directories and files, including build artifacts and configuration files.

@Copilot Copilot AI review requested due to automatic review settings May 6, 2025 15:38
@bingenito bingenito requested a review from a team as a code owner May 6, 2025 15:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to ESLint9 by adding a new ESLint configuration file, enforcing license header compliance across files, and updating documentation for lint commands.

  • Added standardized license headers to various source and test files.
  • Updated ESLint configuration in eslint.config.mjs with new rules and plugins.
  • Updated README.md to include linting instructions.

Reviewed Changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/desktopjs/vite.config.ts Added license header to the Vite configuration.
packages/desktopjs/tests/setup.ts Added license header to the test setup file.
packages/desktopjs-openfin/vite.config.ts Added license header to the OpenFin Vite configuration.
packages/desktopjs-openfin/tests/openfin.spec.ts Made minor type adjustments and style improvements in test callbacks.
packages/desktopjs-openfin/src/openfin.ts Refactored getState to use an explicit if/else for improved readability.
packages/desktopjs-electron/vite.config.ts Added license header to the Electron Vite configuration.
packages/desktopjs-electron/tests/setup.ts Added license header to the Electron test setup file.
eslint.config.mjs Introduced updated ESLint configuration with license header enforcement.
README.md Included new instructions for linting commands.
Files not reviewed (3)
  • .eslintrc.json: Language not supported
  • package.json: Language not supported
  • tsconfig.test.json: Language not supported

@bingenito bingenito merged commit 9103e16 into morganstanley:main May 6, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants