chore: Upgrade to eslint9 #734
Conversation
bingenito
commented
May 2, 2025
bingenito
commented
- Introduced ESLint9 configuration file with rules and license header enforcement.
- Added license header to missing files via lint:fix
- Configured ESLint to ignore specific directories and files, including build artifacts and configuration files.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the ESLint configuration to version 9 and enforces the inclusion of Apache License headers in various project files, while also updating several test and source files to align with new linting rules and improved type annotations.
- Added/updated ESLint configuration and license headers in multiple config files.
- Updated test and source files to use more explicit function signatures and control flow.
- Enhanced documentation in the README with new linting instructions.
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/desktopjs/vite.config.ts | Added license header. |
| packages/desktopjs/tests/setup.ts | Added license header. |
| packages/desktopjs-openfin/vite.config.ts | Added license header. |
| packages/desktopjs-openfin/tests/openfin.spec.ts | Updated test callbacks and function signatures; improved event typings. |
| packages/desktopjs-openfin/src/openfin.ts | Refactored getState to use an explicit if/else for clarity. |
| packages/desktopjs-electron/vite.config.ts | Added license header. |
| packages/desktopjs-electron/tests/setup.ts | Added license header. |
| eslint.config.mjs | Introduced ESLint9 configuration with license header enforcement. |
| README.md | Added new linting instructions. |
Files not reviewed (3)
- .eslintrc.json: Language not supported
- package.json: Language not supported
- tsconfig.test.json: Language not supported
| @@ -902,7 +857,7 @@ describe("OpenFinContainer", () => { | |||
|
|
|||
| try { | |||
| await (container as any).isAutoStartEnabledAtLogin(); | |||
| expect(true).toBe(false); // This will fail the test if we get here | |||
| expect(true).toBe(false); | |||
There was a problem hiding this comment.
[nitpick] Consider using an explicit fail() function or a more descriptive failure mechanism instead of 'expect(true).toBe(false)' to make the test failure clearer.
| expect(true).toBe(false); | |
| fail("The function did not throw an error as expected."); |
Copilot uses AI. Check for mistakes.
| @@ -166,7 +166,12 @@ export class OpenFinContainerWindow extends ContainerWindow { | |||
|
|
|||
| public getState(): Promise<any> { | |||
| return new Promise<any>(resolve => { | |||
| (this.nativeWindow && (<any>this.nativeWindow).getState) ? resolve((<any>this.nativeWindow).getState()) : resolve(undefined); | |||
| // Use explicit if/else instead of ternary for side-effect | |||
| if (this.nativeWindow && (<any>this.nativeWindow).getState) { | |||
There was a problem hiding this comment.
[nitpick] Consider replacing the cast with a proper type guard or explicit type conversion to improve type safety and maintainability.
Copilot uses AI. Check for mistakes.
