Skip to content

chore: Upgrade to eslint9 #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

bingenito
Copy link
Member

  • Introduced ESLint9 configuration file with rules and license header enforcement.
  • Added license header to missing files via lint:fix
  • Configured ESLint to ignore specific directories and files, including build artifacts and configuration files.

@Copilot Copilot AI review requested due to automatic review settings May 2, 2025 13:00
@bingenito bingenito requested a review from a team as a code owner May 2, 2025 13:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to ESLint9, adds automatic license header enforcement to files missing them, and updates the linter configuration and documentation.

  • Introduces a new ESLint9 configuration file with an enforced license header rule.
  • Adds license header comments to various configuration, test, and source files.
  • Updates ignore patterns and README instructions for linting.

Reviewed Changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/desktopjs/vite.config.ts Added license header at the top.
packages/desktopjs/tests/setup.ts Added license header to the Jest setup file.
packages/desktopjs-openfin/vite.config.ts Added license header at the top.
packages/desktopjs-openfin/tests/openfin.spec.ts Updated license header and adjusted event listener type annotations.
packages/desktopjs-openfin/src/openfin.ts Replaced ternary with explicit if/else in getState for clarity.
packages/desktopjs-electron/vite.config.ts Added license header at the top.
packages/desktopjs-electron/tests/setup.ts Added license header to the Jest setup file.
eslint.config.mjs New ESLint9 configuration including license header enforcement.
README.md Added linting instructions and commands.
Files not reviewed (3)
  • .eslintrc.json: Language not supported
  • package.json: Language not supported
  • tsconfig.test.json: Language not supported

@bingenito bingenito closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant