Skip to content

Refactor ESLint and npm ignore configurations; remove unused files #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

bingenito
Copy link
Member

Declutter workspace root:

  • npmignore is unncessary as each package.json has dist section of allowed files
  • whitesource is no longer used
  • eslint ignore can be inside eslint config

@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 13:13
@bingenito bingenito requested a review from a team as a code owner April 30, 2025 13:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • .eslintignore: Language not supported
  • .eslintrc.json: Language not supported
  • .npmignore: Language not supported
  • .whitesource: Language not supported

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (49adb72) to head (7fd5340).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   73.98%   73.98%           
=======================================
  Files          16       16           
  Lines        1507     1507           
  Branches      317      301   -16     
=======================================
  Hits         1115     1115           
- Misses        367      392   +25     
+ Partials       25        0   -25     
Flag Coverage Δ
unittests 73.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bingenito bingenito requested a review from kruplm April 30, 2025 13:14
@bingenito bingenito marked this pull request as draft April 30, 2025 15:28
@bingenito bingenito marked this pull request as ready for review April 30, 2025 15:28
@bingenito bingenito merged commit 4b77973 into morganstanley:main Apr 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants