Count object extension headers in bytes, not fields #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to skip those without parsing, and easier to parse without trial decoding. Fixes moq-wg#718
vasilvv
requested review from
kixelated,
suhasHere and
ianswett
as code owners
suhasHere
reviewed
Feb 25, 2025
draft-ietf-moq-transport.md
Outdated
| * Object Extension Count: The number of Object Extensions present. A value of 0 | ||
| indicates that no Object Extension Headers are present. | ||
| * Object Extension Size: The total size of the Object Extension Headers block, | ||
| in bytes. |
There was a problem hiding this comment.
we need to update Canonical Field section as well.
There was a problem hiding this comment.
This is the Canonical Object Fields section, though?
suhasHere
reviewed
Feb 25, 2025
draft-ietf-moq-transport.md
Outdated
| @@ -2680,7 +2680,7 @@ STREAM_HEADER_GROUP { | |||
| } | |||
| { | |||
| Object ID = 0 | |||
| Extension Count = 2 | |||
| Extension Headers Size = 33 | |||
There was a problem hiding this comment.
:) did you count the bytes to be 33 :-)
There was a problem hiding this comment.
Yes, but I did it in a calculator, so it may be not 33 (and of course, varint serialization is ambiguous).
ianswett
reviewed
Feb 25, 2025
ianswett
approved these changes
Feb 25, 2025
afrind
reviewed
Feb 26, 2025
suhasHere
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to skip those without parsing, and easier to parse without trial decoding.
Fixes #718