Skip to content

Add an error code for Too Far Behind #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add an error code for Too Far Behind #620

merged 4 commits into from
Dec 2, 2024

Conversation

afrind
Copy link
Collaborator

@afrind afrind commented Nov 15, 2024

This error code can be sent by a publisher to a subscriber that is not consuming data fast enough, causing a queue to form at the publisher that exceeds the publisher's limits.

Fixes: #462
Fixes: #582

This error code can be sent by a publisher to a subscriber that is not consuming data fast enough, causing a queue to form at the publisher that exceeds the publisher's limits.

Fixes: #462
This helps address #582
@afrind
Copy link
Collaborator Author

afrind commented Nov 16, 2024

I added text here on when to send Too Far Behind that attempts to clarify the fidelity of subscribe. It ended up in the delivery timeout section, which may not be where it belongs, but we don't have a generic section that explains how subscriptions work, it's spread amongst the relay section, SUBSCRIBE message and Delivery Timeout.

@ianswett ianswett added the Subscribe Related to SUBSCRIBE message and subscription handling label Nov 25, 2024
Co-authored-by: ianswett <[email protected]>
@ianswett ianswett added the Design Issues or PRs that change how MoQ works including the wire format. label Dec 2, 2024
@ianswett ianswett merged commit 517de55 into main Dec 2, 2024
2 checks passed
@englishm englishm mentioned this pull request Feb 25, 2025
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issues or PRs that change how MoQ works including the wire format. Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the fidelity of SUBSCRIBE Limits on the amount of buffered data
3 participants