Clarify MAX_SUBSCRIBE_ID #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt at clarifying MAX_SUBSCRIBE_ID, feel free to make suggestions. Fixes #547
ianswett
added
the
Editorial
afrind
reviewed
Nov 11, 2024
draft-ietf-moq-transport.md
Outdated
| More on Subscribe ID in {{message-subscribe-req}}. | ||
| equal or larger than this is received by the publisher that sent the | ||
| MAX_SUBSCRIBE_ID, the publisher MUST close the session with an error of | ||
| 'Too Many Subscribes'. More on Subscribe ID in {{message-subscribe-req}}. |
There was a problem hiding this comment.
What you have is fine, but "More on Subscribe ID in ..." is awkward. Just add a section reference on line 1841 after "Subscribe ID"
suhasHere
approved these changes
Nov 11, 2024
fluffy
approved these changes
Nov 12, 2024
|
lgtm |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at clarifying MAX_SUBSCRIBE_ID, feel free to make suggestions.
Fixes #547