Skip to content

Relays terminate QUIC connections #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Relays terminate QUIC connections #538

merged 2 commits into from
Sep 25, 2024

Conversation

afrind
Copy link
Collaborator

@afrind afrind commented Sep 23, 2024

Fixes: #336

Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but given Webtransport is also a substrate MoQ runs over, I think we want to avoid using QUIC connection?

Comment on lines 686 to 687
Relays are MoQ endpoints, which means they terminate the underlying QUIC
connections in order to have visibility of MoQ Object metadata.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Relays are MoQ endpoints, which means they terminate the underlying QUIC
connections in order to have visibility of MoQ Object metadata.
Relays are MoQ endpoints, which means they terminate the MoQ session
in order to have visibility of MoQ Object metadata.

Also minor cleanup of capitalization and definition
Copy link
Collaborator

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but given Webtransport is also a substrate MoQ runs over, I think we want to avoid using QUIC connection?

@ianswett ianswett merged commit 88675b6 into main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can something be considered a MoQT relay if it does not terminate QUIC?
4 participants