Skip to content

The end MUST be after the start #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

ianswett
Copy link
Collaborator

@ianswett ianswett commented Apr 30, 2024

Fixes #296

The other option is we can use a delta encoding to make it impossible to specify an earlier object, but I think that would make it more complex.

@ianswett ianswett added the Subscribe Related to SUBSCRIBE message and subscription handling label Apr 30, 2024
Copy link
Collaborator

@vasilvv vasilvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After or equals to?

(in case one requests a single object)

@ianswett
Copy link
Collaborator Author

Good point, I changed it to the same or later object

Copy link
Collaborator

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianswett ianswett merged commit 7078789 into main May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty subscriptions
4 participants