Skip to content

Clarify that SUBSCRIBE and ANNOUNCE generate only one response #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2023
Merged

Clarify that SUBSCRIBE and ANNOUNCE generate only one response #274

merged 2 commits into from
Oct 16, 2023

Conversation

fluffy
Copy link
Collaborator

@fluffy fluffy commented Oct 16, 2023

Fixes #261

@ianswett ianswett mentioned this pull request Oct 16, 2023
Closed
ianswett
ianswett reviewed Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but I'd like to make these MUSTs, ie: exactly one response MUST be sent and if more than one is received, it's a protocol violation.

@ianswett ianswett mentioned this pull request Oct 16, 2023
Merged
@fluffy fluffy requested a review from ianswett October 16, 2023 17:18
@ianswett ianswett merged commit 12b724c into main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianswett ianswett ianswett approved these changes

@kixelated kixelated Awaiting requested review from kixelated

@suhasHere suhasHere Awaiting requested review from suhasHere suhasHere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can you have subscribe error after OK
3 participants
@fluffy @kixelated @ianswett