Skip to content

rewrite model section #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2023
Merged

rewrite model section #172

merged 3 commits into from
May 26, 2023

Conversation

fluffy
Copy link
Collaborator

@fluffy fluffy commented May 25, 2023

No description provided.

The application is solely responsible for the contents of objects.
This includes the underlying encoding, compression, any end-to-end encryption, or authentication.
A relay MUST NOT combine, split, or otherwise modify object payloads.
Objects are comprised of two parts: metadata and a payload. The metadata is visible to relays but the payload is only visible to the producer and consumer. The application is solely responsible for the content of the object payload.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not loose priority and TTL in metadata here.

Copy link
Collaborator

@kixelated kixelated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spent a while debating the object/group text so I'd prefer smaller changes.

@@ -167,36 +167,32 @@ x (b):
: Indicates that x consists of a variable length integer, followed by that many bytes of binary data.


# Model
# Object Model {#model}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about working top-down right than bottom up?

I think it makes more sense to describe tracks first, and then groups, and then objects, and then anything smaller (application).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree .. This was my suggestion on google docs too . Its more natural that way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had the same suggestion, though I think reading bottom up is still getting the job done. If we're pressed for time today for -05, I would leave this and revisit it later.

The application is solely responsible for the contents of objects.
This includes the underlying encoding, compression, any end-to-end encryption, or authentication.
A relay MUST NOT combine, split, or otherwise modify object payloads.
Objects are comprised of two parts: metadata and a payload. The metadata is visible to relays but the payload is only visible to the producer and consumer. The application is solely responsible for the content of the object payload.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payload is opaque and possibly encrypted to the relays

@@ -167,36 +167,32 @@ x (b):
: Indicates that x consists of a variable length integer, followed by that many bytes of binary data.


# Model
# Object Model {#model}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree .. This was my suggestion on google docs too . Its more natural that way.

@suhasHere suhasHere changed the base branch from editorial-moves to main May 26, 2023 17:40
@suhasHere suhasHere merged commit 37821c8 into moq-wg:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants