Update peer dependency to support karma 6
#427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opted to `lastest`, the reasoning is TS is defined as `lastest`. Fixes monounity#409
- updates peer dependencies mark to support `karma` v6 - update `karma` dependency to `6.1.0` - update `@types/karma` to `6.1.0` `karma` 6.1.0 is breaking (kind of), mostly for Dart users. Should not have direct impact on Karma TS integration, but peer dependency definiiton makes using v6 impossible. Hence this change. Tested locally, changes applied and tested in all packages, except of: - Docker (requires app rewrite, it fails at runtime due to yars/args error) - Gulp plugin (I cannot take a dent on how it works) Thanks!
|
Awesome, thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
karmav6karmadependency to6.1.0@types/karmato6.1.0karma6.1.0 is breaking (kind of), mostly for Dart users. Should not have direct impact on Karma TS integration, but peer dependency definiiton makes using v6 impossible. Hence this change.Tested locally, changes applied and tested in all packages, except of:
Thanks!
Update acorn.parse usage to support
ecmaVersionOpted to
lastest, the reasoning is TS is defined aslastest.Fixes #409
[README] bump copy year and minor cleanup