-
Notifications
You must be signed in to change notification settings - Fork 576
Increase Linux support #3209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Linux support #3209
Conversation
Errors are existing in Tests: Mac Catalyst (macOS) https://dev.azure.com/xamarin/public/_build/results?buildId=138165 |
# Conflicts: # scripts/Docker/debian/clang-cross/build-local.sh # scripts/azure-templates-stages.yml
# Conflicts: # native/linux-clang-cross/build.cake # scripts/Docker/_clang-cross-common.sh # scripts/Docker/alpine/clang-cross/Dockerfile # scripts/Docker/alpine/clang-cross/build-local.sh # scripts/Docker/debian/clang-cross/build-local.sh # scripts/azure-templates-stages.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we cross compile all archs, then we don't need these arch specific ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having issues with cross-compiling all archs. Debian x64 to x64 and Alpine x86. Once I get those to build then I can drop.
string TOOLCHAIN_ARCH = Argument("toolchainArch", EnvironmentVariable("TOOLCHAIN_ARCH")); | ||
string TOOLCHAIN_ARCH_SHORT = Argument("toolchainArchShort", EnvironmentVariable("TOOLCHAIN_ARCH_SHORT")); | ||
string TOOLCHAIN_ARCH_TARGET = Argument("toolchainArchTarget", EnvironmentVariable("TOOLCHAIN_ARCH_TARGET")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now define these in the Docker container instead of having it calculated in other places each time we use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running file output/path/libSkiaSharp.so
will validate if we are producing the correct arch/bitness compared to main branch
Something is wrong with the dotnet installer script host. So nothing is working on CI. I am trying to get someone to have a look. |
@4Darmygeometry did you not understand what he meant by "CI issue"? i have told you the same thing earlier |
I understand the meaning of "CI issue". I just want to see how to solve the download problem of .net |
It may just be me, but I am feeling that there may be a bit of hostility here. Please make sure that everyone feels welcome so we are all able to work together. Keep in mind that there are many different cultures and languages here that may cause misunderstandings. |
they deleted the context of the conversation, comments before mine. so it seems like it. what you are missing is:
so me being blunt is a problem for you and they stealing my work isn't? |
Hi folks, The builds are now available on the preview feed: https://aka.ms/skiasharp-eap/index.json As soon as you let me know, I can release this to NuGet and then hopefully a stable version shortly afterwards. |
Description of Change
After updating all the skia versions, agents and Dpcker files, we ended up on Debian 10 which uses GLIBC 2.31 which broke the support for RHEL 8.
This PR drops down the version of the build Docker to Debian 10 which is also still under ELTS.
One reason we went to Debian 11 was the depot_tools required Python 3.8, and Debian 10 only went up to Python 3.7. However, I found that there was just a single file that had 3.8 requirements and that was just because they wrote it using a new mechanism. There was a slightly different way in 3.7, so I opened an issue https://issues.chromium.org/issues/403485632 and then also a https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6355868. Once (hopefully) the CL gets merged, I can remove the workaround in the cake files.
This PR has grown a bit and in an effort to not have many conflicts and double work, I merged in #3200.
This PR now has arm, arm64, x86, x64, riscv64 builds for glibc and musl, both normal and no-fontconfig.
Bugs Fixed