Skip to content

v1.6.1 - Conditionally ignore serverless connection string changes #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Dec 4, 2022

Description

Because of how the dependency chains works on serverless, serverless privatelink endpoints, and serverless privatelink endpoint services, serverless instance connection strings state cannot be determined on the initial terraform apply.

When these tests run, they do a terraform refresh and see unexpected pending changes to those connection strings.

Now the config can conditionally ignore changes to those connection strings, which we do in certain first applications of these resources to avoid these test failures.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@Zuhairahmed
Copy link
Contributor

Thanks @evertsd, just double checking do we need to include new optional timeout flags to Resource: privatelink_endpoint_service_adl and Resource: private_endpoint_regional_mode as well?

Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks approving per Slack and moved add configurable timeouts to resources that wait for clusters to become IDLE to INTMDB-508.

Copy link

@matt-condon matt-condon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the detailed description 🏅

@evertsd evertsd merged commit 9db9f90 into master Dec 6, 2022
@martinstibbe martinstibbe deleted the v1.6.1_pe_tests branch January 4, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants