Skip to content

Fix serverless endpoint tests #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2022
Merged

Fix serverless endpoint tests #949

merged 3 commits into from
Dec 1, 2022

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Dec 1, 2022

Description

Fixed test failures introduced in INTMDB-465
Ignoring connection strings on resource & added data source, dependent on endpoint_service_serverless, to verify that the behavior which was ignored on the resource still works.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@evertsd evertsd requested a review from a team as a code owner December 1, 2022 23:30
@evertsd evertsd requested a review from Zuhairahmed December 1, 2022 23:31
Zuhairahmed
Zuhairahmed approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed Zuhairahmed merged commit 1040025 into master Dec 1, 2022
@evertsd evertsd deleted the INTMDB-465-tests branch December 4, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evertsd @Zuhairahmed