Skip to content

docs(resource/role_mapping): indent sub-elements of role_assignments #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

Horgix
Copy link
Contributor

@Horgix Horgix commented Nov 14, 2022

Description

In the context of the federated_settings_org_role_mapping, group_id and roles are only meaningful as sub-elements of the role_assignments field. This simply indents them accordingly.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

No meaningful test to add.

Further comments

None.

In the context of the `federated_settings_org_role_mapping`, `group_id`
and `roles` are only meaningful as sub-elements of the
`role_assignments` field. This simply indents them accordingly.
@Horgix Horgix requested a review from a team as a code owner November 14, 2022 09:11
@Zuhairahmed Zuhairahmed self-requested a review November 14, 2022 15:14
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zuhairahmed Zuhairahmed merged commit fca313a into mongodb:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants