docs(website): fix federated_settings_org_config resource name by removing the misleading trailing s
#908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoving the misleading trailing `s` Due to the file name, the resource `federated_settings_org_config` is actually caled `federated_settings_org_configs` in the Terraform Registry documentation (notice the superfluous trailing `s`). This simply renames the file to fix this.
|
CLA signed ✔️ 🙂 Approved on my company's side by @francoisfanuel |
Zuhairahmed
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Thanks @Horgix! Also confirming that you signed our CLA, this is a good catch. LGTM
|
Thanks for the reviews! What's the next step to get this merged? Do I need to do anything else on my end? 🙂 |
|
Just merged @Horgix , thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the file name, the resource
federated_settings_org_configis actually caledfederated_settings_org_configsin the Terraform Registry documentation (notice the superfluous trailings).This simply renames the file to fix this.
Type of change:
Required Checklist:
I didn't find any clean way to "test" the website part so I left that unchecked. I'd be happy to read any instructions on how to validate such a documentation change!
Further comments
None.