INTMDB-363: [Updated Feature] Add serverless backup to mongodbatlas_serverless_instance #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinstibbe
requested review from
andreaangiolillo and
themantissa
as code owners
themantissa
requested changes
Sep 8, 2022
| @@ -24,6 +24,7 @@ resource "mongodbatlas_serverless_instance" "test" { | |||
| provider_settings_backing_provider_name = "AWS" | |||
| provider_settings_provider_name = "SERVERLESS" | |||
| provider_settings_region_name = "US_EAST_1" | |||
| continuous_backup_enabled = true | |||
There was a problem hiding this comment.
We have included a lot of optional parameters in examples and later regretted it. So let's not add them unless it's required.
There was a problem hiding this comment.
Removed continuous_backup_enabled
| @@ -35,6 +36,7 @@ resource "mongodbatlas_serverless_instance" "test" { | |||
| * `provider_settings_provider_name` - (Required) Cloud service provider that applies to the provisioned the serverless instance. | |||
| * `provider_settings_region_name` - (Required) | |||
| Human-readable label that identifies the physical location of your MongoDB serverless instance. The region you choose can affect network latency for clients accessing your databases. | |||
| * `continuous_backup_enabled` - (Optional) Flag that indicates whether the serverless instance uses Serverless Continuous Backup. If this parameter is false, the serverless instance uses Basic Backup. | |||
There was a problem hiding this comment.
Basic is fine for data source but let's include some links here to explain these backup types:
Suggested change
| * `continuous_backup_enabled` - (Optional) Flag that indicates whether the serverless instance uses Serverless Continuous Backup. If this parameter is false, the serverless instance uses Basic Backup. | |
| * `continuous_backup_enabled` - (Optional) Flag that indicates whether the serverless instance uses [Serverless Continuous Backup](https://www.mongodb.com/docs/atlas/configure-serverless-backup). If this parameter is false or not used, the serverless instance uses [Basic Backup](https://www.mongodb.com/docs/atlas/configure-serverless-backup). |
There was a problem hiding this comment.
Added additional information
themantissa
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Add support for use_org_and_group_names_in_export_prefix parameter (#829) * INTMDB-381: Add support to ignore export bucket when auto_export_enabled = false (#823) * Add support to ignore export bucket when auto_export_enabled = false * Update mongodbatlas/resource_mongodbatlas_cloud_backup_schedule.go Co-authored-by: Andrea Angiolillo <[email protected]> * go fmt * go fmt Co-authored-by: Andrea Angiolillo <[email protected]> * INTMDB-354: [Terraform] Update docs around what requires an API key access list (#834) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-354: [Terraform] Update docs around what requires an API key access list * Expand detail in documentation for API key list * Add additional resources that require API Key access list Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-383: [Terraform] Update the BYOK/encryption at rest resource (#832) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update key rotation alert to 90 days vs 365 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-363: [Updated Feature] Add serverless backup to mongodbatlas_serverless_instance (#830) * Add support for ServerlessContinuousBackupEnabled * Update datasources, tests and documentation * Update docs add link for backup information * INTMDB-342: [Terraform] Update TestAccDataSourceMongoDBAtlasPrivateEndpointRegionalMode_basic test to use a new project to prevent conflicts (#837) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MONGODB_ATLAS_NETWORK_PROJECT_ID to permit multi region testing to run in different project Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update tests related to alert configuratiopn (#836) * INTMDB-387: Enable Azure NVME for Atlas Dedicated clusters (#833) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Azure as validation candidate for NVME * Split out Azure setting Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Fix create index error msg (#824) * INTMDB-386 Defer project_invitation role validation to api (#840) * Update project_invitation documentation and removed validations on roles * Updated role documentation on project_invitation * Added role documentation onto the argument reference * INTMDB-347: [Terraform] cloud_backup is not being correctly imported - issue 768 (#839) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support to migrate legacy backup parameter to cloud_backup value * Update error message Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-358: [terraform] Upgrade to go1.18 (#835) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update build to go 1.18 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-371: PrivateLink Endpoint Timeout (#841) * Updated privatelink_endpoint CD endpoints to match refresh func timeout * Using Configured timeout times in refresh func * Updated docs to contain timeout instructions * Corrected default timeout value on privatelink_endpoint * Moved the timeout documentation to the resource * PrivateLink Endpoint documentation refers to the proper resource and includes an example * Fixed casing on Private Endpoint * Added to docs on how to learn more about timeouts * Update CHANGELOG.md * Add links * Update CHANGELOG.md Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eliot Boutherin <[email protected]> Co-authored-by: Dosty Everts <[email protected]>
martinstibbe
added a commit
that referenced
this pull request
Sep 16, 2022
* Add support for use_org_and_group_names_in_export_prefix parameter (#829) * INTMDB-381: Add support to ignore export bucket when auto_export_enabled = false (#823) * Add support to ignore export bucket when auto_export_enabled = false * Update mongodbatlas/resource_mongodbatlas_cloud_backup_schedule.go Co-authored-by: Andrea Angiolillo <[email protected]> * go fmt * go fmt Co-authored-by: Andrea Angiolillo <[email protected]> * INTMDB-354: [Terraform] Update docs around what requires an API key access list (#834) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-354: [Terraform] Update docs around what requires an API key access list * Expand detail in documentation for API key list * Add additional resources that require API Key access list Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-383: [Terraform] Update the BYOK/encryption at rest resource (#832) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update key rotation alert to 90 days vs 365 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-363: [Updated Feature] Add serverless backup to mongodbatlas_serverless_instance (#830) * Add support for ServerlessContinuousBackupEnabled * Update datasources, tests and documentation * Update docs add link for backup information * INTMDB-342: [Terraform] Update TestAccDataSourceMongoDBAtlasPrivateEndpointRegionalMode_basic test to use a new project to prevent conflicts (#837) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MONGODB_ATLAS_NETWORK_PROJECT_ID to permit multi region testing to run in different project Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update tests related to alert configuratiopn (#836) * INTMDB-387: Enable Azure NVME for Atlas Dedicated clusters (#833) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Azure as validation candidate for NVME * Split out Azure setting Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Fix create index error msg (#824) * INTMDB-386 Defer project_invitation role validation to api (#840) * Update project_invitation documentation and removed validations on roles * Updated role documentation on project_invitation * Added role documentation onto the argument reference * INTMDB-347: [Terraform] cloud_backup is not being correctly imported - issue 768 (#839) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support to migrate legacy backup parameter to cloud_backup value * Update error message Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-358: [terraform] Upgrade to go1.18 (#835) * Chore(deps): Bump github.com/gruntwork-io/terratest (#825) Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update build to go 1.18 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * INTMDB-371: PrivateLink Endpoint Timeout (#841) * Updated privatelink_endpoint CD endpoints to match refresh func timeout * Using Configured timeout times in refresh func * Updated docs to contain timeout instructions * Corrected default timeout value on privatelink_endpoint * Moved the timeout documentation to the resource * PrivateLink Endpoint documentation refers to the proper resource and includes an example * Fixed casing on Private Endpoint * Added to docs on how to learn more about timeouts * Update CHANGELOG.md * Add links * Update CHANGELOG.md * Remove Azure unrelated EBS encryption flag for NVME disks Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andrea Angiolillo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eliot Boutherin <[email protected]> Co-authored-by: Dosty Everts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Updated Feature] Add serverless backup to mongodbatlas_serverless_instance
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments