Skip to content

Update CONTRIBUTING.md #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

Update CONTRIBUTING.md #798

merged 1 commit into from
Aug 2, 2022

Conversation

themantissa
Copy link
Collaborator

@themantissa themantissa commented Jul 29, 2022 •
edited by gssbzn
Loading

Description

Clarify use of release branch in the contributing file.

Please include a summary of the fix/feature/change, including any relevant motivation and context.
N/A

Link to any related issue(s): N/A

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • [ X] Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa
Update CONTRIBUTING.md
cf8fd41 
Clarify use of release branch
martinstibbe
martinstibbe approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gssbzn
gssbzn approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we should explain that master represents production and a staging branch is used for development but I can do that follow up, this makes it easier to follow already

@themantissa themantissa merged commit 71b9173 into master Aug 2, 2022
@themantissa themantissa deleted the update-contributing branch August 2, 2022 15:57
Zuhairahmed added a commit to Zuhairahmed/terraform-provider-mongodbatlas that referenced this pull request Aug 4, 2022
@Zuhairahmed
Revert "Update CONTRIBUTING.md (mongodb#798)"
147159c 
This reverts commit 71b9173.
Zuhairahmed added a commit to Zuhairahmed/terraform-provider-mongodbatlas that referenced this pull request Aug 4, 2022
@Zuhairahmed
Revert "Revert "Update CONTRIBUTING.md (mongodb#798)""
007ab2c 
This reverts commit 147159c.
themantissa added a commit that referenced this pull request Aug 5, 2022
@Zuhairahmed @themantissa
INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Docu…
9f7688a 
…mentation (#803)

* Update CONTRIBUTING.md (#798)

Clarify use of release branch

* INTMDB-362

Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only.

* Revert "Update CONTRIBUTING.md (#798)"

This reverts commit 71b9173.

* Revert "Revert "Update CONTRIBUTING.md (#798)""

This reverts commit 147159c.

Co-authored-by: Melissa Plunkett <[email protected]>
martinstibbe added a commit that referenced this pull request Aug 16, 2022
@martinstibbe @gssbzn
@evertsd @Zuhairahmed @themantissa
Release staging v1.4.4 (#810)
01c5f3f 
* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support (#797)

* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support

* feat: Update to use go1.17

* actually update

Co-authored-by: Gustavo Bazan <[email protected]>

* Setting name on project data_source read (#795)

* INTMDB-331 - Update GCP documentation (#793)

* Updated gcp compute address & forwarding rule examples

* Fixed formatting

* Commenting out credentials for fmting purposes

* Updated import documentation for global_cluster_config (#796)

* INTMDB-355: [Terraform] Customer HELP ticket - hitting panic when trying to set maintenance windows (#800)

* INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Documentation   (#803)

* Update CONTRIBUTING.md (#798)

Clarify use of release branch

* INTMDB-362

Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only.

* Revert "Update CONTRIBUTING.md (#798)"

This reverts commit 71b9173.

* Revert "Revert "Update CONTRIBUTING.md (#798)""

This reverts commit 147159c.

Co-authored-by: Melissa Plunkett <[email protected]>

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade (#799)

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade

* Ran go mod tidy -compat=1.17

* Fix test to use aws provider ctedentials (#807)

* Update CHANGELOG.md

* go mod tidy

* Go lang lint update to v1.41.2

* GOLANGCI_VERSION=v1.42.1

* Try latest

* Fix go.sum

* golangci version

* tidy

* fixes

* fixes

* Update resource_mongodbatlas_database_user_test.go

Co-authored-by: Gustavo Bazan <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Melissa Plunkett <[email protected]>
guineveresaenger pushed a commit to pulumi/terraform-provider-mongodbatlas that referenced this pull request Sep 13, 2022
@themantissa @guineveresaenger
Update CONTRIBUTING.md (mongodb#798)
6946456 
Clarify use of release branch
guineveresaenger pushed a commit to pulumi/terraform-provider-mongodbatlas that referenced this pull request Sep 13, 2022
@martinstibbe @gssbzn
@evertsd @Zuhairahmed @themantissa @guineveresaenger
Release staging v1.4.4 (mongodb#810)
a34c733 
* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support (mongodb#797)

* INTMDB-343: Update go from 1.16 to 1.17 add windows arm64 build support

* feat: Update to use go1.17

* actually update

Co-authored-by: Gustavo Bazan <[email protected]>

* Setting name on project data_source read (mongodb#795)

* INTMDB-331 - Update GCP documentation (mongodb#793)

* Updated gcp compute address & forwarding rule examples

* Fixed formatting

* Commenting out credentials for fmting purposes

* Updated import documentation for global_cluster_config (mongodb#796)

* INTMDB-355: [Terraform] Customer HELP ticket - hitting panic when trying to set maintenance windows (mongodb#800)

* INTMDB-362: Header Clarifications "Resource" vs "Data Source" in Documentation   (mongodb#803)

* Update CONTRIBUTING.md (mongodb#798)

Clarify use of release branch

* INTMDB-362

Header Clarifications "Resource" vs "Data Source" to be more in line with other providers as well to make easier for user. Documentation update only.

* Revert "Update CONTRIBUTING.md (mongodb#798)"

This reverts commit 71b9173.

* Revert "Revert "Update CONTRIBUTING.md (mongodb#798)""

This reverts commit 147159c.

Co-authored-by: Melissa Plunkett <[email protected]>

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade (mongodb#799)

* INTMDB-357: Add exclude to skip go-header until google terraform provider version tag upgrade

* Ran go mod tidy -compat=1.17

* Fix test to use aws provider ctedentials (mongodb#807)

* Update CHANGELOG.md

* go mod tidy

* Go lang lint update to v1.41.2

* GOLANGCI_VERSION=v1.42.1

* Try latest

* Fix go.sum

* golangci version

* tidy

* fixes

* fixes

* Update resource_mongodbatlas_database_user_test.go

Co-authored-by: Gustavo Bazan <[email protected]>
Co-authored-by: Dosty Everts <[email protected]>
Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: Melissa Plunkett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@martinstibbe martinstibbe martinstibbe approved these changes

@Zuhairahmed Zuhairahmed Awaiting requested review from Zuhairahmed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themantissa @gssbzn @martinstibbe