Skip to content

INTMDB-323 Remove beta requirement for serverless #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Jul 11, 2022

Description

Removed the requirement to set MONGODB_ATLAS_ENABLE_BETA to use serverless and update the docs to match.

Internal ticket INTMDB-323

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change to remove that it's in preview as it's now GA - but preserve the link to the limitations.

@evertsd evertsd requested a review from themantissa July 13, 2022 02:18
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix. LGTM!

Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit for code cleanup

@evertsd evertsd merged commit 445bbb3 into release-staging-v1.4.3 Jul 13, 2022
@martinstibbe martinstibbe mentioned this pull request Jul 13, 2022
10 tasks
martinstibbe added a commit that referenced this pull request Jul 13, 2022
* Updated serverless instance documentation to be correct (#782)

* INTMDB-335 and INTMDB-348: backup - Add option for multiple weekly monthly schedules and fix autoexport  (#784)

* INTMDB-335: Add option for multiple weekly monthly schedules and Fix missing auto_export_enabled flag setting add test for export example

* Correct restore_window_days

* Split out export test

* Update CHANGELOG.md

* Set export to computed to avoid drift in existing configurations

* Update CHANGELOG.md

* Add support for delaying deletion of mongodbatlas_cloud_backup_snapshot_export_bucket

* Delete __debug_bin

* Add additional user supplied PR

* Update CHANGELOG.md

* INTMDB-323 Remove beta requirement for serverless (#783)

* Removed serverless beta documentation and resource requirement

* Added commented out example beta features and added an early return to avoid lint errors

* Removed text about serverless being in preview, it's not

* Addressed nit, removed examples

Co-authored-by: Dosty Everts <[email protected]>
@gssbzn gssbzn deleted the INTMDB-323 branch July 26, 2022 08:19
guineveresaenger pushed a commit to pulumi/terraform-provider-mongodbatlas that referenced this pull request Sep 13, 2022
* Updated serverless instance documentation to be correct (mongodb#782)

* INTMDB-335 and INTMDB-348: backup - Add option for multiple weekly monthly schedules and fix autoexport  (mongodb#784)

* INTMDB-335: Add option for multiple weekly monthly schedules and Fix missing auto_export_enabled flag setting add test for export example

* Correct restore_window_days

* Split out export test

* Update CHANGELOG.md

* Set export to computed to avoid drift in existing configurations

* Update CHANGELOG.md

* Add support for delaying deletion of mongodbatlas_cloud_backup_snapshot_export_bucket

* Delete __debug_bin

* Add additional user supplied PR

* Update CHANGELOG.md

* INTMDB-323 Remove beta requirement for serverless (mongodb#783)

* Removed serverless beta documentation and resource requirement

* Added commented out example beta features and added an early return to avoid lint errors

* Removed text about serverless being in preview, it's not

* Addressed nit, removed examples

Co-authored-by: Dosty Everts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants