INTMDB-298: fixes a bug where you couldn't delete a team in team resource #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderGo93
requested review from
abner-dou and
andreaangiolillo
as code owners
andreaangiolillo
approved these changes
Feb 4, 2022
Comment on lines
+224
to
+232
| var target *matlas.ErrorResponse | ||
| if errors.As(err, &target) && target.ErrorCode != "USER_UNAUTHORIZED" { | ||
| return diag.Errorf("error removing team(%s) from the project(%s): %s", teamID, projectID, err) | ||
| } |
There was a problem hiding this comment.
[nit] I wouldn’t silently ignore the error USER_UNAUTHORIZED but at least print a warning so that the user is aware that the team removal operation failed because they don't have the correct permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CANNOT_DELETE_TEAM_ASSIGNED_TO_PROJECTwhen trying to delete one team in team resourceLink to any related issue(s): #662
Type of change:
Required Checklist:
Further comments