Skip to content

INTMDB-284: Updated docs in alert configuration resource and datasource #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2022
Merged

INTMDB-284: Updated docs in alert configuration resource and datasource #645

merged 3 commits into from
Jan 10, 2022

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Dec 21, 2021 •
edited
Loading

Description

  • Updated docs of resource and datasource of alert configuration for parameter email_enabled , sms_enabled and roles

Link to any related issue(s):
#632

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Dec 21, 2021
themantissa
themantissa requested changes Dec 22, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few edits for clarity

themantissa
themantissa approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thetonymaster
thetonymaster approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderGo93 coderGo93 merged commit a764900 into master Jan 10, 2022
@coderGo93 coderGo93 deleted the INTMDB-284 branch January 10, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees

@coderGo93 coderGo93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coderGo93 @themantissa @thetonymaster @andreaangiolillo