Skip to content

INTMDB:273: Fix replication_specs update error #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2021
Merged

INTMDB:273: Fix replication_specs update error #607

merged 3 commits into from
Nov 16, 2021

Conversation

abner-dou
Copy link
Contributor

Description

When update replication_specs property, the provider tried to send an empty id, so this fix gets the saved id and send to the API on change of this property

Also a minor changed to the acceptance_test naming (from acceptances_test -> acceptance_test)

Link to any related issue(s):INTMDB-237 #588

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@abner-dou abner-dou added the run-testacc To run acceptance tests label Nov 15, 2021
@abner-dou abner-dou self-assigned this Nov 15, 2021
themantissa
themantissa approved these changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thetonymaster
thetonymaster approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreaangiolillo
andreaangiolillo approved these changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abner-dou abner-dou merged commit d1ab4f8 into master Nov 16, 2021
@abner-dou abner-dou deleted the INTMDB-273-backup branch November 16, 2021 16:27
@lantoli lantoli mentioned this pull request Dec 13, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees

@abner-dou abner-dou

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abner-dou @themantissa @thetonymaster @andreaangiolillo