Skip to content

Update cloud_provider_snapshots.html.markdown #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

nhuray
Copy link
Contributor

@nhuray nhuray commented Nov 13, 2021

Description

Minor typo on the name of the resource

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Minor typo on the name of the resource
@nhuray nhuray requested a review from themantissa as a code owner November 13, 2021 03:10
@themantissa
Copy link
Collaborator

Thank you @nhuray for the PR but this is actually correct. There is both a mongodbatlas_cloud_provider_snapshot and mongodbatlas_cloud_provider_snapshots, this is the data source doc for mongodbatlas_cloud_provider_snapshots. Hence closing this PR out.

@nhuray
Copy link
Contributor Author

nhuray commented Nov 15, 2021

@themantissa

There's datasources mongodbatlas_cloud_provider_snapshot and mongodbatlas_cloud_provider_snapshots but if I'm not mistaken there's only 1 resource mongodbatlas_cloud_provider_snapshot (without s).

Just to let you know I also spotted some discrepancies in the documentation using group_id instead of project_id. I guess the code has been updated recently but the documentation is still behind.

Regards,

@themantissa themantissa reopened this Nov 15, 2021
@themantissa
Copy link
Collaborator

@nhuray I obviously missed that. You are correct. If you can sign our CLA I can approve and merge this.

Originally projects were called groups. Due to that there's still places in the Atlas docs, this work included, that still contain groups instead of projects. As we find them we correct them but if you see one feel free to submit a PR.

@nhuray
Copy link
Contributor Author

nhuray commented Nov 16, 2021

@themantissa I just signed the CLA.

I'll try during the week to submit another PR with the discrepancies I found.

Regards,

@themantissa
Copy link
Collaborator

@nhuray thank you! Appreciate the contribution.

@themantissa themantissa merged commit a3b6359 into mongodb:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants