INTMDB-270: Added 'with_default_alerts_settings' to project resource #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantissa
requested changes
Nov 3, 2021
| @@ -91,15 +97,15 @@ func resourceMongoDBAtlasProjectCreate(ctx context.Context, d *schema.ResourceDa | |||
|
|
|||
| project, _, err := conn.Projects.Create(ctx, projectReq, createProjectOptions) | |||
| if err != nil { | |||
| return diag.FromErr(fmt.Errorf(errorProjectCreate, err)) | |||
There was a problem hiding this comment.
This is not in the PR description, can you describe? Is this updates for the newer SDK that weren't made yet?
There was a problem hiding this comment.
I was working on this file and I noticed this, the correct use is diag.Errorf(.....) not diag.FromErr(fmt.Errorf(....)) (this way works but is not correct)
There was a problem hiding this comment.
Glad to have it corrected but next time this kind of things come up please describe it and why in the PR description. That way it's not a surprise. Thank you.
abner-dou
added a commit
that referenced
this pull request
Nov 15, 2021
…595) * added 'with_default_alerts_settings' to project resource * change project documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new property (
with_default_alerts_settings) was added toprojectresource in order to disable default alerts on project creation. this property is set totrueby defaultLink to any related issue(s):INTMDB-270
Type of change:
Required Checklist:
Further comments