Skip to content

INTMDB-269: Fix issue with default auto_scaling_disk_gb_enabled value #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 22, 2021

Conversation

abner-dou
Copy link
Contributor

@abner-dou abner-dou commented Oct 13, 2021

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):INTMDB-269

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

TEST RESULT:

--- PASS: TestAccResourceMongoDBAtlasCluster_tenant (1558.34s)
PASS
coverage: 6.8% of statements
ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 1560.775s coverage: 6.8% of statements
? github.com/mongodb/terraform-provider-mongodbatlas/version [no test files]

@abner-dou abner-dou added the run-testacc To run acceptance tests label Oct 13, 2021
@abner-dou abner-dou self-assigned this Oct 13, 2021
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk with @coderGo93 about adding some tests with this, since those tests might need to be added with terratest

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure that all the tests are passing before asking for a review. Thanks!
Changes LGTM.

@abner-dou abner-dou added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Oct 14, 2021
@abner-dou abner-dou added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Oct 15, 2021
@abner-dou abner-dou added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Oct 17, 2021
@abner-dou abner-dou added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Oct 18, 2021
@abner-dou abner-dou removed the run-testacc To run acceptance tests label Oct 19, 2021
@abner-dou abner-dou added the run-testacc To run acceptance tests label Oct 19, 2021
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just squash the fix commits, since just a fix message is annoying

@abner-dou abner-dou merged commit e66aa30 into master Oct 22, 2021
@abner-dou abner-dou deleted the INTMDB-269 branch October 22, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants