-
Notifications
You must be signed in to change notification settings - Fork 190
INTMDB-269: Fix issue with default auto_scaling_disk_gb_enabled value #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talk with @coderGo93 about adding some tests with this, since those tests might need to be added with terratest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure that all the tests are passing before asking for a review. Thanks!
Changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you just squash the fix commits, since just a fix message is annoying
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):INTMDB-269
Type of change:
Required Checklist:
Further comments
TEST RESULT:
--- PASS: TestAccResourceMongoDBAtlasCluster_tenant (1558.34s)
PASS
coverage: 6.8% of statements
ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 1560.775s coverage: 6.8% of statements
? github.com/mongodb/terraform-provider-mongodbatlas/version [no test files]