Skip to content

INTMDB-181: Detects unnecessary changes changes for azure/gcp encryption at rest #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Feb 12, 2021

Description

Fixes:

  • After created then terraform, it will appear unnecessary changes when using azure or gcp in encryption at rest.

Tests:

  • Working without problems(Not appearing changes after plan) for GCP
  • Now working for azure too

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Feb 12, 2021
@coderGo93 coderGo93 changed the title WIP: INTMDB-181: Detects unnecessary changes changes for azure/gcp encryption at rest INTMDB-181: Detects unnecessary changes changes for azure/gcp encryption at rest Feb 12, 2021
@leofigy
Copy link
Contributor

leofigy commented Feb 13, 2021

Hi Edgar, looks good to me, thanks for testing with azure , please go ahead and merge

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending on if passes tests, it sounds like, for both providers. Thank you!

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Mar 12, 2021
@coderGo93 coderGo93 merged commit 8a31066 into master Mar 12, 2021
@coderGo93 coderGo93 deleted the INTMDB-181 branch March 12, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants