Skip to content

INTMDB-158: Added private endpoint in connection strings #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 27, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Jan 27, 2021

Description

  • Added private_endpoint for schema connection_strings in resource and datasource(s) of cluster
  • Updated docs for resource and datasource(s) of cluster
  • Modified test using the new private endpoint instead of deprecated ones

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Tests will fail until it can be updated with recent version of client mongodb because of a bug related to object of PrivateEndpoint

@coderGo93 coderGo93 self-assigned this Jan 27, 2021
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once the go client is updated the test should pass. Just need DoU review. Thanks!

Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Jan 27, 2021
@coderGo93 coderGo93 merged commit fea51f6 into master Jan 27, 2021
@coderGo93 coderGo93 deleted the INTMDB-158 branch January 27, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants