Path escape import id of database user

[KeisukeYamashita]

Description

I path escaped the user input id for mongodbatlas_database_user.
When I tried to import DB user for AWS role type user, I ran this command.

$ terraform import mongodbatlas_database_user.my_db_user 'MASKED_ATLAS_PROJECT_ID-arn:aws:iam::MASKED_AWS_PROJECT_ID:role/my-role-$external'

But got this error.

Error: couldn't import user(arn:aws:iam::MASKED_AWS_PROJECT_ID:role:role/my-role) in project(MASKED_ATLAS_PROJECT_ID), error: GET https://cloud.mongodb.com/api/atlas/v1.0/groups/MASKED_ATLAS_PROJECT_ID/databaseUsers/$external/arn:aws:iam::MASKED_ATLAS_PROJECT_ID:role/my-role: 404 (request "Not Found") Cannot find resource /api/atlas/v1.0/groups/MASKED_ATLAS_PROJECT_ID/databaseUsers/$external/arn:aws:iam::MASKED_ATLAS_PROJECT_ID:role:role/my-role.

But if I run the command below (with / path escaped), it's okay:

$ terraform import mongodbatlas_database_user.my_db_user 'MASKED_ATLAS_PROJECT_ID-arn:aws:iam::MASKED_AWS_PROJECT_ID:role%2Fmy-role-$external'

I want the script to handle the space, not developers so that developers can import much easier.

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the Terraform contribution guidelines
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

[themantissa]

@KeisukeYamashita good catch! @leofigy @coderGo93 or @marinsalinas can one of you review as well? Seems we missed the escape for import but got it for read update delete. Thanks!

[marinsalinas]

Nice catch!! LGTM!

[themantissa]

@coderGo93 can you merge this and ensure the tests run/pass so we can make sure the import doesn't have any issues?

[KeisukeYamashita]

Thank you all for your reviews 👍

@themantissa Do you have any plans for when it will this change will be released? I want this PR change and this change to be released because I use this resource and it's preventing me to update it.

[themantissa]

@KeisukeYamashita eta is mid this month so should be soon.

[KeisukeYamashita]

Got it. Thank you for your reply👍