Skip to content

INTMDB-147: Changed to required in schema of roles for database users #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2021
Merged

INTMDB-147: Changed to required in schema of roles for database users #371

merged 1 commit into from
Jan 7, 2021

Conversation

coderGo93
Copy link
Contributor

Description

Changed to required parameter for roles of database users.

Tested the same acceptance tests TestAccResourceMongoDBAtlasDatabaseUser_withRoles and it passed

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@coderGo93 coderGo93 self-assigned this Dec 22, 2020
themantissa
themantissa approved these changes Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY!

marinsalinas
marinsalinas approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Jan 7, 2021
@coderGo93 coderGo93 merged commit cabc520 into master Jan 7, 2021
@coderGo93 coderGo93 deleted the INTMDB-147 branch January 7, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@themantissa themantissa themantissa approved these changes

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @marinsalinas @themantissa