INTMDB-133: Examples for encryption at rest with roles

[coderGo93]

Description

To use terratest locally you need to generate the binary first with go install, then plugin will find the binary by following this information Plugin locations otherwise it will get the plugin from terraform registry website.

To run certain test with terratest you can go to directory of integration-testing and run go test -v -run TestTerraformResourceMongoDBAtlasEncryptionAtRestWithRole_basicAWS

Link to any related issue(s):

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the Terraform contribution guidelines
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

[themantissa]

@nikhil-mongo would you be able to take a look at this example and review it? It's for the recent add of IAM roles and the upcoming change for new use to go from IAM user to IAM roles.

[nikhil-mongo]

Please add the attributes for accesskey and secret key

Error: error creating Encryption at Rest: PATCH https://cloud.mongodb.com/api/atlas/v1.0/groups/5dd0f66379358e17e49d6c40/encryptionAtRest: 400 (request "Bad Request") The required attribute accessKeyID was not specified.

  on atlas-encryption.tf line 1, in resource "mongodbatlas_encryption_at_rest" "test":
   1: resource "mongodbatlas_encryption_at_rest" "test" {

atlas-encryption.tf

resource "mongodbatlas_encryption_at_rest" "test" {
  project_id = var.project_id
  aws_kms = {
    access_key_id = var.access_key
    secret_access_key = var.secret_key
    enabled                = true
    customer_master_key_id = var.customer_master_key
    region                 = var.atlas_region
    role_id = var.cpa_role_id
  }
}

[coderGo93]

Hi @nikhil-mongo , it seems the error is because is not getting the current "version" aka binary, if you don't indicate to use certain version locally it will get from terraform website which is not updated/released yet, so in order to use locally you need to generate the binary first with go install then specify in tf to use locally hence the commented line with version in versions.tf, I just updated little in the description, let me know if you have more questions/issues.
PD: Terratest is like if you are using terraform commands in terminal kinda different for acceptance test since it can always use the current version(binary) you are developing but for this case is different and it seems more useful with terratest

[nikhil-mongo]

@coderGo93 I have developed the provider by cloning the master branch and using it from inside ~/.terraform.d/plugins.
I am able to perform all the operations except this second-step, as it is missing the required parameters access_key_id and secret_access_key as per the file resource_mongodbatlas_encryption_at_rest.go line 44-52. I added them to the atlas-encryption.tf and was able to complete the deployment. Please update these and then it is good to go.

[coderGo93]

Understood @nikhil-mongo , will add those attributes then, thank you!!

[nikhil-mongo]

@coderGo93 Please run terraform fmt in the second step directory. Rest LGTM.

[themantissa]

@nikhil-mongo thank you! If you are good can you approve this PR?

[nikhil-mongo]

Approved

[themantissa]

@coderGo93 so Nik approved the example in the examples directly but there are 1700+ files in this repo. Can we just do the examples, then do a PR just for the integration-testing add (so if anyone needs the bigger test for IAM they have it) and then ensure there's no provider related code in here (there is currently).

[themantissa]

I don't think this should be in the PR.

[leofigy]

LGTM

[themantissa]

LGTM, sorry for the delay on my part!